Ticket #10748 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create ConvertUnitsUsingDetectorTable algorithm

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Ross Whitfield

Description

This is an offshot of #9880 but rather than fold the functionality into the current ConvertUnits command, create a separate algorithm so we don't cause any unintended issues.

Change History

comment:1 Changed 6 years ago by Stuart Campbell

Added ConvertUnitsUsingDetectorTable()

Basically a copy of ConvertUnits() that takes an extra parameter. This algorithm will be 'trimmed' later. refs #10748

Changeset: 47e84f8b51d004070eff7a0e39738bac07cc2031

comment:2 Changed 6 years ago by Stuart Campbell

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #101.

comment:3 Changed 6 years ago by Stuart Campbell

Fix class name in header. refs #10748

Changeset: 4ef4a47a53bdd53d3ca7e1000d2e2fde022d42ad

comment:4 Changed 6 years ago by Stuart Campbell

Put into hidden category for now. refs #10748

Changeset: 5568135e80e5b5ca657e06464cc67b227f7ad237

comment:5 Changed 6 years ago by Stuart Campbell

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:6 Changed 6 years ago by Stuart Campbell

  • Status changed from reopened to inprogress

comment:7 Changed 6 years ago by Stuart Campbell

  • Priority changed from critical to major
  • Milestone changed from Release 3.3 to Release 3.4

comment:8 Changed 5 years ago by Stuart Campbell

Adding skeleton of new ConvertUnitsUisngDetectorTable algorithm

refs #10748

Changeset: 4724681b2c5a4f732e9e6e76b3490d74d0a5d615

comment:9 Changed 5 years ago by Stuart Campbell

Copied Exec() from ConvertUnits(). refs #10748

Changeset: 11bb5be022c2f141e66b678b03c8d0b899e9bfe6

comment:10 Changed 5 years ago by Stuart Campbell

Added basic functional body of algorithm

Only does the conversion via TOF at the moment refs #10748

Changeset: 14ea7056220ef62943dbbfb7d426c9dfa900fedc

comment:11 Changed 5 years ago by Stuart Campbell

Changed algorithm category to indicate developmental status

refs #10748

Changeset: 7f1de62f6530acdd4a4fce5fb7380ffb196d08fb

comment:12 Changed 5 years ago by Stuart Campbell

Added debug statement

refs #10748

Changeset: cf245119ed45cb4b7f2db62a423b78527cdbcc1d

comment:13 Changed 5 years ago by Stuart Campbell

Commit changes from crashed os! refs #10748

Changeset: 3ce7aa48c5ecb67cdc36ca42374a560ad239d6f5

comment:14 Changed 5 years ago by Stuart Campbell

Added updates from old disk. refs #10748

Changeset: a189ca9a10bcc4ada60dc8d76dba45218abfda33

comment:15 Changed 5 years ago by Stuart Campbell

Added docs and usage example. refs #10748

Changeset: 10f2662a77d3f6e7c3e22f0db2130bfe99e126c8

comment:16 Changed 5 years ago by Stuart Campbell

Various changes and cleanup

  • Removed parallel regions for converting to/from TOF as it seemed to

give random errors (as in values that were 10x too big).

  • Cleaned up Test

refs #10748

Changeset: 0ab492f6952cf71b1b0ab202892f8e380dd8d47e

comment:17 Changed 5 years ago by Stuart Campbell

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #636.

comment:18 Changed 5 years ago by Stuart Campbell

Correct cppcheck problems. refs #10748

Changeset: b35db6c09209aae563cbf77e4ccbb3623b3c9659

comment:19 Changed 5 years ago by Stuart Campbell

Fix compilation error on rhel6. refs #10748

Changeset: 4678845285b3d6c893eeba9b78366872b45dbd90

comment:20 Changed 5 years ago by Stuart Campbell

To Test: As this is a new algorithm (under development), then running some examples similar to the usage tests / unit test should be ok. It isn't used by any other algorithm yet.

comment:21 Changed 5 years ago by Stuart Campbell

I really do not understand why the Windoze builds are failing - Anyone any ideas ?

comment:22 Changed 5 years ago by Karl Palmen

Yes. I think the scheduling of the Windows builds may have gone wrong, so one begins before the previous as finished and this causes a failure of the one just begun, because it can't delete a file.

comment:23 Changed 5 years ago by Karl Palmen

That idea was wrong. There are two ISIS windows build servers. See slack-general for more details.

comment:24 Changed 5 years ago by Stuart Campbell

Removed unused debugging code. refs #10748

Changeset: 05e28daa14c80b817174c26dec5361aee407c99b

comment:25 Changed 5 years ago by Ross Whitfield

  • Status changed from verify to verifying
  • Tester set to Ross Whitfield

comment:26 Changed 5 years ago by Ross Whitfield

  • Status changed from verifying to closed

Merge pull request #636 from mantidproject/10748_convertunits_detectortable

New algorithm ConvertUnitsUsingDetectorTable

Full changeset: ​e20bed850a61d512ad602f108f1424679f013578

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11590

Note: See TracTickets for help on using tickets.