Ticket #10778 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Indirect Simulation incomplete error report

Reported by: Raquel Alvarez Banos Owned by: Dan Nixon
Priority: minor Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

When loading a silly file in Indirect Simulation (for instance an empty file in MolDyn) an error saying "Error running algorithm. See results log for details" is reported. However, the Results Log window is empty, so the user does not know what went wrong. I have also observed this in Indirect Diffraction.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

From what I have tested:

  • Simulation > Sassena gives a very concise error message (Cannot open /home/dan/empty.h5)
  • Simulation > MolDyn gives a very long/useless Python stack trace (which will be fixed in this ticket)
  • Diffraction gives a series of error messages, the top one does detail the error (Error in execution of algorithm Load: No valid data in file...)

(Note that the test file I used was a literally empty file, they may actually behave differently if the file contains data in an unexpected format.)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Catch loading exceptions

Refs #10778

Changeset: fa7b0a13ed64d9ae962a102948435a8a616d41a7

comment:4 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10778_moldyn_better_error_messages

Refs #10778

Changeset: a188d83545849284343b46f0e361adff6513527c

comment:5 Changed 6 years ago by Dan Nixon

Seperate logging lines

Refs #10778

Changeset: d43afe3aa77d9debc509b93cdd742be5d578497c

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Open Indirect > Simulation > MolDyn
  • Create an empty file with the .cdlextension
  • Select it in the MolDyn interface
  • Enter any function name (e.g. Sqw-total)
  • Run
  • Error in Result Log will state tat file could not be parsed

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into feature/10778_moldyn_better_error_messages

Refs #10778

Full changeset: a188d83545849284343b46f0e361adff6513527c

comment:9 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/feature/10778_moldyn_better_error_messages'

Full changeset: 4d513939ae9ddb46d2abef91edaa8f8dffcdbfb7

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11620

Note: See TracTickets for help on using tickets.