Ticket #10779 (closed: fixed)
Indirect Tools no error message for nonsense chemical formula
Reported by: | Raquel Alvarez Banos | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | #10863 | |
Blocking: | Tester: | Harry Jeffery |
Description
In Indirect Tools, if the chemical formula is left blank, a pop-up error message informing appears. However, if you set the chemical formula to a nonsense value (HHO for instance) no error message if shown. Perhaps this could be added as it is done with a blank chemical formula.
Change History
comment:1 Changed 6 years ago by Dan Nixon
- Owner set to Dan Nixon
- Status changed from new to assigned
comment:3 Changed 6 years ago by Dan Nixon
Added regex to test for chemical formula
Refs #10779
Changeset: 89b178b1f77cbd3c62655434505e9eb9ba5f8c06
comment:5 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10779_indirect_tools_give_error_on_failure
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectTransmissionCalc.cpp
Refs #10779
Changeset: 2399ebf4a8cdb5bca040e074ca709f0bc309047a
comment:6 Changed 6 years ago by Dan Nixon
Have SetSampleMaterial give a nicer error
Refs #10779
Changeset: faba7aa247a062c1e32a52f62387d8148539da35
comment:7 Changed 6 years ago by Dan Nixon
To test:
- Open Indirect > Tools > Transmission
- Select an instrument config
- Provide a valid chemical formula (e.g. V)
- Run
- Provide an invalid chemical formula (e.g. HHO)
- Run, should get an error in Results Log and message box
- Compare the errors given by SetSampleMaterial when an invalid chemical formula is provided
comment:8 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:10 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into feature/10779_indirect_tools_give_error_on_failure
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectTransmissionCalc.cpp
Refs #10779
Full changeset: 2399ebf4a8cdb5bca040e074ca709f0bc309047a
comment:11 Changed 6 years ago by Harry Jeffery
Merge remote-tracking branch 'origin/feature/10779_indirect_tools_give_error_on_failure'
Full changeset: 8b895d184f6f271f4f90d5ffb1cf6b69c82d4728
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11621