Indirect Simulation incomplete error report

[Raquel Alvarez Banos]

When loading a silly file in Indirect Simulation (for instance an empty file in MolDyn) an error saying "Error running algorithm. See results log for details" is reported. However, the Results Log window is empty, so the user does not know what went wrong. I have also observed this in Indirect Diffraction.

[Dan Nixon]

From what I have tested:

• Simulation > Sassena gives a very concise error message (Cannot open /home/dan/empty.h5)
• Simulation > MolDyn gives a very long/useless Python stack trace (which will be fixed in this ticket)
• Diffraction gives a series of error messages, the top one does detail the error (Error in execution of algorithm Load: No valid data in file...)

(Note that the test file I used was a literally empty file, they may actually behave differently if the file contains data in an unexpected format.)

[Dan Nixon]

Catch loading exceptions

Refs #10778

Changeset: fa7b0a13ed64d9ae962a102948435a8a616d41a7

[Dan Nixon]

Merge branch 'master' into feature/10778_moldyn_better_error_messages

Refs #10778

Changeset: a188d83545849284343b46f0e361adff6513527c

[Dan Nixon]

Seperate logging lines

Refs #10778

Changeset: d43afe3aa77d9debc509b93cdd742be5d578497c

[Dan Nixon]

To test:

• Open Indirect > Simulation > MolDyn
• Create an empty file with the .cdlextension
• Select it in the MolDyn interface
• Enter any function name (e.g. Sqw-total)
• Run
• Error in Result Log will state tat file could not be parsed

[Dan Nixon]

Merge branch 'master' into feature/10778_moldyn_better_error_messages

Refs #10778

Full changeset: ​a188d83545849284343b46f0e361adff6513527c

[Harry Jeffery]

Merge remote-tracking branch 'origin/feature/10778_moldyn_better_error_messages'

Full changeset: ​4d513939ae9ddb46d2abef91edaa8f8dffcdbfb7

[Stuart Campbell]

This ticket has been transferred to github issue ​11620