Ticket #10894 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Maintenance ticket for PlotAsymmetryByLogValue

Reported by: Raquel Alvarez Banos Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Muon Keywords: Maintenance
Cc: Blocked By:
Blocking: #7083, #10068 Tester: Harry Jeffery

Description

This is a maintenance ticket for PlotAsymmetryByLogValue algorithm. Ensure that all unit tests pass, as it is used by ALC muon interface.

Change History

comment:1 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Raquel Alvarez Banos

Noticed the following issue: If the first and last runs are not in the same directory an exception is thrown (vector<T> too long). A more specific error message should be printed.

comment:4 Changed 6 years ago by Raquel Alvarez Banos

Re #10894 updating PlotAsymmetryByLogValue algorithm

Changeset: 00e3c71cdc1c7587b642e5c5e56d4d7240023927

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Re #10894 Fixing build plot asymmetry by log value

Changeset: d8a5f963b27dd4b34d33e806ca2137507ee5de84

comment:6 Changed 6 years ago by Raquel Alvarez Banos

For tester: as it is a maintenance ticket, the algorithm should behave as in the master branch. Just play with the different options and check that the algorithm works as before. (Note that the algorithm does not work correctly when "Dead Time Corrections" are loaded "FromSpecifiedFile", this will be addressed in ticket #10886).

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Blocking 10886 removed

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:10 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Exceptions from the child algorithms shouldn't be caught because it hides the actual error messages which can be useful.

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from reopened to inprogress

Re #10894 Removing try blocks that hide actual error messages

Changeset: fe24fcdb29cbb90d1cf945246d4ce7364879b0b9

comment:12 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Nick Draper

comment:14 Changed 6 years ago by Nick Draper

Raquel,

Can you open a pull request for this.

The code is currently not fully merged to develop, but if you open a pull request it removes the need for this.

comment:15 Changed 6 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Nick Draper deleted

comment:16 Changed 6 years ago by Raquel

This is being verified as pull request #228.

comment:17 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:18 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:19 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:20 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:21 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #228 from mantidproject/feature/10894_PlotAsymmetryByLogValue_maintenance

Plot asymmetry by log value maintenance

Full changeset: 831acdb87c3cb184df3e3a1e08dfb45923fe3a07

comment:22 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Muon

comment:23 Changed 5 years ago by Raquel Alvarez Banos

  • Blocking 6931 removed

(In #6931) I have attached a script I have been using to test the changes, which the tester may find useful. It includes descriptions (comments) of what I would expect in each successive execution of the algorithm.

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11733

Note: See TracTickets for help on using tickets.