Ticket #10910 (inprogress)
Improve EnginX expectedPeaks loading for all EnginX algorithms
| Reported by: | Lottie Greenwood | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | Diffraction | Keywords: | |
| Cc: | Blocked By: | #10605 | |
| Blocking: | #8368 | Tester: |
Description
Use .csv file browser/defaults made in #10605 and move it into EnginX Utils, enabling it to be used by the other EnginX algorithms.
Change History
comment:3 Changed 6 years ago by Lottie Greenwood
- Status changed from assigned to inprogress
Refs #10910 changed loading to csv
Changeset: c3770dc7f0a86b428bf398cb6e5004b1b3dbd7d6
comment:4 Changed 6 years ago by Lottie Greenwood
Refs #10910 csv loading added in calibrateFull
Changeset: 95b752c32fabd62f8827d2e1b7618a59ccafe4e8
comment:5 Changed 6 years ago by Lottie Greenwood
Refs #10910 csv loading added in calibrate
Changeset: ead10cb3451beff4bb6ab0dd69d6186d50b92362
comment:6 Changed 5 years ago by Nick Draper
- Milestone changed from Release 3.4 to Release 3.5
Moved to R3.5 at the R3.4 code freeze
comment:7 Changed 5 years ago by Lottie Greenwood
- Owner changed from Lottie Greenwood to Federico M Pouzols
comment:8 Changed 5 years ago by Federico M Pouzols
- Blocking 8368 added
(In #8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.
comment:9 Changed 5 years ago by Federico M Pouzols
To do:
- move _readInExpectedPeaks() and _getDefaultPeaks() from EnginXFitPeaks.py to EnginXUtils.py
- add a property like self.declareProperty(FileProperty(name="ExpectedPeaksFromFile"... in EnginXCalibrate, and EnginXCalibrateFull.
Also, if #10909 and #10967 (the two tickets that add an optional output table with difz, zero) are merged, this ticket could also include:
- refactor/merge the "_produceOutputs() + _generateOutputParFitTable() stuff" from EnginXFitPeaks and EnginXCalibrate (largely duplicate code) and move it into EnginXUtils.py
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11749
