Ticket #10605 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

For EnginX FitPeaks improve ExpectedPeak entry

Reported by: Lottie Greenwood Owned by: Lottie Greenwood
Priority: minor Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #10910 Tester: Dan Nixon

Description (last modified by Lottie Greenwood) (diff)

EngineX FitPeaks dialogue box currently only has a text entry for the expectedPeak values.

Add both a .csv file browser to automatically populate the text entry and set the default values to be for Ce.

Update documentation to reflect this.

Attachments

TESTFILE.csv (9 bytes) - added by Lottie Greenwood 6 years ago.

Change History

comment:1 Changed 6 years ago by Lottie Greenwood

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Lottie Greenwood

  • Description modified (diff)

comment:3 Changed 6 years ago by Lottie Greenwood

  • Status changed from assigned to inprogress

Refs #10605 added defaults for fit peaks and file entry

Changeset: e32e8c6c763542893ee4510446e3dafff46a7ae7

comment:4 Changed 6 years ago by Lottie Greenwood

Refs #10605 set up file loading mechanism

Changeset: 7d03ec856622c40bd803f8f9e7c6dcf3fbef0225

comment:5 Changed 6 years ago by Lottie Greenwood

Refs #10605 Updated fitPeaks documentation

Changeset: e9eec62153595ef56aff58941cff78fbe24b9576

comment:6 Changed 6 years ago by Lottie Greenwood

Refs #10605 added default values

Changeset: abdcf76498893b639372d111a64da14a41a4d487

comment:7 Changed 6 years ago by Lottie Greenwood

  • Milestone changed from Backlog to Release 3.4

Changed 6 years ago by Lottie Greenwood

comment:8 Changed 6 years ago by Lottie Greenwood

To test:

  • Create a workspace with 2 peaks and set instrument geometry using the below in the ipython console
peak1 = "name=BackToBackExponential,I=4000,A=1,B=0.5,X0=12000,S=350"
peak2 = "name=BackToBackExponential,I=5000,A=1,B=0.7,X0=35000,S=300"

# Create workpsace with the above peaks and a single detector pixel
ws = CreateSampleWorkspace(Function="User Defined",
                           UserDefinedFunction=peak1 + ";" + peak2,
                           NumBanks=1,
                           BankPixelWidth=1,
                           XMin=6000,
                           XMax=45000,
                           BinWidth=10)

# Update instrument geometry to something that would allow converting to some sane dSpacing values
EditInstrumentGeometry(Workspace = ws, L2 = [1.5], Polar = [90], PrimaryFlightPath = 50)
  • The set defaults will not work because currently fitPeaks has to be able to fit every expectedPeak in order to run correctly (addressed in #10907) however you can see the defaults are available by opening the algorithm UI for expectedPeaks
  • Test reading in of .csv files (can use file attached with workspace created above). If .csv file contains nothing/non-numerical characters, an error will be thrown.
  • Build and check updated documentation
Last edited 6 years ago by Lottie Greenwood (previous) (diff)

comment:9 Changed 6 years ago by Lottie Greenwood

Refs #10605 checkpointing

Changeset: bb121536756c41d39f1b0ca980d924d82be43d53

comment:10 Changed 6 years ago by Lottie Greenwood

Refs #10605 fixed whitespace issues

Changeset: 3d9cfd022eb11ee2e0a4d32e167ce7095da3c9e5

comment:11 Changed 6 years ago by Lottie Greenwood

Refs #10605 added explanatory text

Changeset: 4a349c42530a1a6d3f23dd806d1f3f902db9f864

comment:12 Changed 6 years ago by Lottie Greenwood

Refs #10605 checkpointing

Changeset: e30c9291bcd6e7e362795edf17583f323c7215c5

comment:13 Changed 6 years ago by Lottie Greenwood

Refs #10605 set defaults

Changeset: f64f25496033520daf0de8ed31275f46cd04131e

comment:14 Changed 6 years ago by Lottie Greenwood

Refs #10605 fixed for doxygen tests

Changeset: b5f20545b031785362797ab84fb98e6eb4f61947

comment:15 Changed 6 years ago by Lottie Greenwood

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 6 years ago by Lottie Greenwood

  • Blocking 10910 added

comment:17 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:18 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10605_improved_ExpectedPeakEntry_for_EnginXFitPeaks'

Full changeset: 25fdc4c6b46694d3a3d803d2528b0e66ce5c3a92

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11447

Note: See TracTickets for help on using tickets.