Ticket #10940 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Horace planner implementation

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 3.4
Component: Direct Inelastic Keywords: SSC, 2015, All
Cc: Blocked By:
Blocking: #9304, #11222 Tester: abuts

Description

There are several planning tools for direct inelastic scattering (Ticket #9304). This one deals with calculating the coverage

Attachments

PlannerImage.png​ (71.8 KB) - added by Alex Buts 5 years ago.

Change History

comment:1 Changed 6 years ago by Andrei Savici

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Andrei Savici

  • Status changed from assigned to inprogress

Start work on HoracePlanner. Refs #10940

Changeset: 82c23ee9b580716092bf588503d43176dfecb8f5

comment:3 Changed 6 years ago by Andrei Savici

Start work on HoracePlanner. Refs #10940

Changeset: a5349ebdc8c4810d50653a42b2ab210f9702ddad

comment:4 Changed 6 years ago by Andrei Savici

Signals, slots, and mantidplot. Refs #10940

Changeset: 7557a09af0be78b4ec8898495fe56766c1f32106

comment:5 Changed 6 years ago by Andrei Savici

Conflicts. Refs #10940

Merge branch 'feature/10940_HoracePlanner' of github.com:mantidproject/mantid into feature/10940_HoracePlanner

Conflicts:

Code/Mantid/scripts/DGSPlanner.py Code/Mantid/scripts/DGSPlanner/ClassicUBInputWidget.py Code/Mantid/scripts/DGSPlanner/DGSPlannerGUI.py Code/Mantid/scripts/DGSPlanner/MatrixUBInputWidget.py

Changeset: 551a6892ff8642192eba5ae3eac9c57699d5954d

comment:6 Changed 6 years ago by Andrei Savici

Instrument widget. Refs #10940

Changeset: 67a08db68cb4f969ca17f3fa55448613369f77ee

comment:7 Changed 6 years ago by Andrei Savici

More on instrument widget. Refs #10940

Changeset: 5a7b8bdd1247bbde0ad71015d43eb3b6cb40915a

comment:8 Changed 6 years ago by Nick Draper

  • Blocking 11222 added

comment:9 Changed 6 years ago by Nick Draper

  • Keywords SSC, 2015, All added

comment:10 Changed 6 years ago by Nick Draper

  • Priority changed from major to critical

Batch modify all SSC tickets to critical priority (this will also show up as an update for all those already as critical)

comment:11 Changed 6 years ago by Andrei Savici

Start working on goniometer. Refs #10940

Changeset: 3f94981a00c58bb38bb55793534f9b2184b0cee1

comment:12 Changed 6 years ago by Andrei Savici

Minor changes for plotting. Refs #10940

Changeset: 7935992bfe89f56c00998507377c3f4db05637c9

comment:13 Changed 6 years ago by Andrei Savici

Validate goniometer settings. Refs #10940

Changeset: d6d3005d2050f3f42469724566ac96e941b98d45

comment:14 Changed 6 years ago by Andrei Savici

Start working on dimension selector. Refs #10940

Changeset: bb862eec0e4339a3a3b157ba86da7126c5903a32

comment:15 Changed 6 years ago by Andrei Savici

Minor changes. Refs #10940

Changeset: 022d06322d933a4b0454876b73b4085a5975cd19

comment:16 Changed 6 years ago by Andrei Savici

Validations and signals. Refs #10940

Changeset: a7b5348b7f25e350a1be30d4a0c4dd9f7c5a250c

comment:17 Changed 6 years ago by Andrei Savici

Update signaling. Refs #10940

Changeset: 342c5a9ff81d6dbf57c27559b652ff43a2b5cc13

comment:18 Changed 6 years ago by Andrei Savici

Finished connections. Refs #10940

Things left to do:

  1. Create workspaces
  2. Calculate the MD coverage
  3. Do the plot
  4. Help page. Check to see if using assistant makes sense

Changeset: 642366c8c6b6d8d2469b9d3860c8f01b77157866

comment:19 Changed 6 years ago by Andrei Savici

Allow non-orthogonal axes plots. Refs #10940

Changeset: 564f5d5709c93f452d6587ccee0c4b23482ce8be

comment:20 Changed 6 years ago by Andrei Savici

Start working on creating workspaces. Refs #10940

Changeset: 5c649756290f77e9f8b2c52c4ef481c17591fdbe

comment:21 Changed 6 years ago by Andrei Savici

Calculate initial workspaces. Refs #10940

Changeset: 4d305308422d031c7d64a9f1449436e0f8e28d6f

comment:22 Changed 6 years ago by Andrei Savici

Fix for limits calculations. Refs #10940

Changeset: 437fd5010667869a61ae1ff5b1ab50e1f4d028c1

comment:23 Changed 6 years ago by Andrei Savici

More on MD coverage. Refs #10940

Changeset: ddefc959e312700ce361482bbf1000bb87cfca63

comment:24 Changed 6 years ago by Andrei Savici

Finishing touches. Refs #10940

Changeset: fdee5fddd7c05e70971e9f4ab4d08a8cbceee16c

comment:25 Changed 6 years ago by Andrei Savici

Add more info to saved figure. Refs #10940

Changeset: bb19341db9960d5069203b707ef89fd39c8b6cda

comment:26 Changed 6 years ago by Andrei Savici

Latest fixes and documentation. Refs #10940

Changeset: 835adeccaf8a5b2aeb1bbe1ec7dcb3e1d4bd4ac2

comment:27 Changed 6 years ago by Andrei Savici

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #535.

comment:28 Changed 6 years ago by Andrei Savici

Note, there should be only one extra pylint warning, a TODO section.

comment:29 Changed 5 years ago by Andrei Savici

Changes to make it work with windows. Refs #10940

Changeset: a5d795a312c7f1cf328163dab296d27900b491a8

Changed 5 years ago by Alex Buts

comment:30 Changed 5 years ago by Alex Buts

There are minor annoyances, e.g. goniometer picture on windows looks ugly + after short work all menus shifted incoherently, (see the picture attached) but otherwise very good.

It would be also nice to have a progress bar and possibility to cancel the calculations.

Will merge it as soon as the tests passed.

comment:31 Changed 5 years ago by Alex Buts

Re #10940 Trivial conflict

Merge branch 'master' into feature/10940_HoracePlanner

Conflicts:

Code/Mantid/Framework/Properties/Mantid.properties.template

Changeset: 0ea42595d96e1c539df654658f0ec21c153029f5

comment:32 Changed 5 years ago by abuts

  • Status changed from verify to closed
  • Tester set to abuts

Merge pull request #535 from mantidproject/feature/10940_HoracePlanner

Feature/10940 horace planner

Full changeset: ​93c0818f8917198aa082f2b550581f9db07ea95d

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11779

Note: See TracTickets for help on using tickets.