Ticket #10941 (new)

Opened 6 years ago

Last modified 5 years ago

A few SINQ classes don't have unit tests: SINQHMListener, SINQTranspose3D, PoldiPeakDetection2, ... PoldiLoadSpectra

Reported by: Federico M Pouzols Owned by:
Priority: major Milestone: Backlog
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester:

Description

While checking how #8492 could be tested, I realized that there is no test for SINQHMListener. Other classes in Framework/SINQ are also missing a unit test:

  • PoldiRemoveDeadWires
  • PoldiPeakDetection2
  • PoldiLoadLog
  • PoldiLoadChopperSlits
  • PoldiAutoCorrelation5
  • PoldiLoadIPP
  • PoldiLoadSpectra
  • SINQTranspose3D

(all are algorithms).

Probably this is not terribly critical for these classes taken one at a time, but the fact that a good bunch of them don't have unit tests looks a bit reckless.

RST documentation is also missing for:

  • SINQTranspose3D
  • PoldiPeakDetection2
  • PoldiAutoCorrelation5

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Summary changed from A few SINQ classes don't have unit tests: SINQHMListener, SINQTranspose3D, PoldiPeakDetection2, PoldiRemoveDeadWires, PoldiLoadLog, PoldiLoadChopperSlits, PoldiAutoCorrelation5, PoldiLoadIPP, PoldiLoadSpectra to A few SINQ classes don't have unit tests: SINQHMListener, SINQTranspose3D, PoldiPeakDetection2, ... PoldiLoadSpectra

The title was very long.

comment:2 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11780

Note: See TracTickets for help on using tickets.