Ticket #8492 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix unreleased use of POCO::XML document or nodelists in SINQHMListener

Reported by: Karl Palmen Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords: maintenance
Cc: Blocked By:
Blocking: #10637 Tester: Harry Jeffery

Description (last modified by Karl Palmen) (diff)

In SINQHMListener, I found a case of POCO::XML document or nodelist objects being created, but not released. This could cause memory leakage. Fix by using AutPtr for the object.

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

comment:2 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:4 Changed 6 years ago by Federico M Pouzols

  • Blocking 10637 added

comment:5 Changed 6 years ago by Federico M Pouzols

  • Owner set to Federico M Pouzols
  • Status changed from assigned to inprogress

comment:6 Changed 6 years ago by Federico Montesino Pouzols

Use Poco::AutoPtr, remove unnecessary headers, re #8492

Changeset: b9b37995b592f3189895d8ee5c8e343bd05567a1

comment:7 Changed 6 years ago by Federico M Pouzols

  • Milestone changed from Backlog to Release 3.4

comment:8 Changed 6 years ago by Federico Montesino Pouzols

correct issue after conflict merge, re #8492

Changeset: 08d8deff67668d02dab4a4cc4d1a67089e06ed70

comment:9 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

There is no test for this class (see related maintenance ticket #10941). Actually I realized that this class may not be used at all in the Mantid code. Anyway, there doesn't seem to be any issue with the builds (removed headers, etc. seem fine on all platforms).

Suggestion to test:

  • check that builds are fine on all platforms (apparently no issue here)
  • review code

comment:10 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:11 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge branch 'master' into bugfix/8492_fix_unreleased_poco_xml_objects_sinqhmlistener

Conflicts:

Code/Mantid/Framework/SINQ/src/SINQHMListener.cpp

Merging master after the clang reformatting, there were no real conflicts

Full changeset: ​95361b8ed1c0dfed6f5623019a12893b37ad1855

comment:12 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/bugfix/8492_fix_unreleased_poco_xml_objects_sinqhmlistener'

Full changeset: ​abc3ded48db6cb6b4d44d3fd684a2353009bf39d

comment:13 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9336

Note: See TracTickets for help on using tickets.