Ticket #10977 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Poco 1.6.0 upgrade introduces compiler warnings

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

Today homebrew upgraded poco to 1.6.0. After upgrading Mantid generates the compiler warnings below. It looks like both Mantid and poco define the macros GCC_DIAG_ON and GCC_DIAG_OFF.

[279/2621] Building CXX object Framework/Geometry/CMakeFiles/Geometry.dir/src/Rendering/OCGeometryRenderer.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Geometry/src/Rendering/OCGeometryRenderer.cpp:6: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Geometry/src/Rendering/OCGeometryRenderer.cpp:6: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [283/2621] Building CXX object Framework/Geometry/CMakeFiles/Geometry.dir/src/Rendering/OCGeometryGenerator.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Geometry/src/Rendering/OCGeometryGenerator.cpp:13: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Geometry/src/Rendering/OCGeometryGenerator.cpp:13: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [594/2621] Building CXX object Framework/PythonInterface/mantid/api/CMakeFiles/PythonAPIModule.dir/src/Exports/AlgorithmFactory.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp:4: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp:4: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [649/2621] Building CXX object Framework/PythonInterface/mantid/api/CMakeFiles/PythonAPIModule.dir/src/Exports/FunctionFactory.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/PythonInterface/mantid/api/src/Exports/FunctionFactory.cpp:3: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/PythonInterface/mantid/api/src/Exports/FunctionFactory.cpp:3: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [1263/2621] Building CXX object Framework/LiveData/CMakeFiles/LiveData.dir/src/ISISHistoDataListener.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/LiveData/src/ISISHistoDataListener.cpp:14: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/LiveData/src/ISISHistoDataListener.cpp:14: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [1270/2621] Building CXX object Framework/LiveData/CMakeFiles/LiveData.dir/src/ISISLiveEventDataListener.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/LiveData/src/ISISLiveEventDataListener.cpp:12: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/LiveData/src/ISISLiveEventDataListener.cpp:12: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [1288/2621] Building CXX object Framework/MDEvents/CMakeFiles/MDEvents.dir/src/MDGridBox.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDGridBox.cpp:8: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDGridBox.cpp:8: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [1574/2621] Building CXX object Framework/MDEvents/CMakeFiles/MDEvents.dir/src/MDEventFactory.cpp.o In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDEventFactory.cpp:21: In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDGridBox.cpp:8: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:56:9: warning: 'GCC_DIAG_OFF' macro redefined #define GCC_DIAG_OFF(x) GCC_DIAG_PRAGMA(ignored GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:85:11: note: previous definition is here

#define GCC_DIAG_OFF(x)

In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDEventFactory.cpp:21: In file included from /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/MDEvents/src/MDGridBox.cpp:8: /Users/svh/Documents/MantidProject/mantid/Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h:57:9: warning: 'GCC_DIAG_ON' macro redefined #define GCC_DIAG_ON(x) GCC_DIAG_PRAGMA(warning GCC_DIAG_JOINSTR(-W, x))

/usr/local/include/Poco/Platform_POSIX.h:86:11: note: previous definition is here

#define GCC_DIAG_ON(x)

2 warnings generated. [2621/2621] Linking CXX executable bin/MantidPlot.app/Contents/MacOS/MantidPlot

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #10977. Undefine macros defined by poco

Changeset: 8a53dae646b3e51b6d333ce83d73a051ba003ce5

comment:2 Changed 6 years ago by Steven Hahn

Revert "Refs #10977. Undefine macros defined by poco"

This reverts commit 8a53dae646b3e51b6d333ce83d73a051ba003ce5.

Changeset: af586c388b8272c68820d6e19ef5f88231decb4a

comment:3 Changed 6 years ago by Steven Hahn

Refs #10977. Simpler way to Undefine macros

Changeset: 36b46669920a276078f8633214c5d09cfc19ddd1

comment:4 Changed 6 years ago by Steven Hahn

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #144.

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico M Pouzols

Oddly enough the last build failed on a couple of platforms because of the git-checkout issue again. The same checkout command worked well on the other platforms.

comment:7 Changed 6 years ago by Federico M Pouzols

Well the changes are obviously fine but just to make sure I'm going to try with a 'retest this please'. Not sure if it will work when I write it...

comment:8 Changed 6 years ago by Federico M Pouzols

retest this please

comment:9 Changed 6 years ago by Harry Jeffery

retest this please

comment:10 Changed 6 years ago by Federico M Pouzols

Thanks Harry for re-starting the build. For some reason the bug in the Jenkins plugin really likes this pull request. It failed again on 3 platforms!

comment:11 Changed 6 years ago by Steven Hahn

retest this please

comment:12 Changed 6 years ago by Federico M Pouzols

All looks good and the builds went through at last.

comment:13 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #144 from mantidproject/feature/10977_fix_poco_1p6p0_warnings

Fix poco 1.6.0 warnings

Full changeset: ​fcab5916b67e57f6e1a459711010a776de64759a

comment:14 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11816

Note: See TracTickets for help on using tickets.