Ticket #10999 (closed: fixed)
Fix error in concatenating string and run number in PostProcessAdmin (ISIS)
| Reported by: | Ian Bush | Owned by: | Lottie Greenwood |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Tools | Keywords: | |
| Cc: | lottie.greenwood@…, marcus.noble@… | Blocked By: | |
| Blocking: | Tester: | Ian Bush |
Description
In the ISIS post processor there is a bug when trying to concatenate an integer (from JSON) and a string.
The problem line is:
run_output_dir = TEMP_ROOT_DIRECTORY + instrument_dir[:instrument_dir.find('/'+ self.data['run_number'])+1]
self.data['run_number']+` comes out as an integer, causing a crash.
Change History
comment:3 Changed 6 years ago by Lottie Greenwood
- Status changed from assigned to verify
- Resolution set to fixed
fixed here in pull request: https://github.com/mantidproject/autoreduce/pull/4
comment:4 Changed 6 years ago by Ian Bush
- Status changed from verify to verifying
- Tester set to Ian Bush
Note: See
TracTickets for help on using
tickets.
Currently fixed on the autoreduction server, in /usr/bin/PostProcessAdmin.py as:
run_output_dir = TEMP_ROOT_DIRECTORY + instrument_dir[:instrument_dir.find('/'+ str(self.data['run_number']))+1]