Ticket #11000 (closed: fixed)
Move to newer CMAKE
Reported by: | Owen Arnold | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description (last modified by Peter Peterson) (diff)
Move to CMAKE 2.8.12. This should be the minimum requirement. We can't do anything with the visibility and public/private until this is done.
Change History
comment:2 Changed 6 years ago by Peter Peterson
- Status changed from assigned to inprogress
- Description modified (diff)
comment:3 Changed 6 years ago by Pete Peterson
Re #11000. Removing un-needed Find*.cmake files
Changeset: 519cca19201f4a9589aa4dc333ec06ef37b0bc59
comment:4 Changed 6 years ago by Pete Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #291.
comment:6 Changed 6 years ago by Pete Peterson
FindPythonLibs.cmake doesn't appear to find what it wants automatically on ubuntu.
comment:8 Changed 6 years ago by Pete Peterson
Comment from @martyngigg on slack: We need to make sure we keep the version of macro(CXXTEST_ADD_TEST) that is in our finder though as it's modified from the original (I'm not sure why)
comment:10 Changed 6 years ago by Pete Peterson
It worked!!!!!!! Most of the work was cleaning out cmake cache from the build servers.
Same testing rules as mentioned in the original description.
comment:11 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:12 Changed 6 years ago by Martyn Gigg
I tried a quick build of the Python layer in debug mode under Windows as that's not covered by the builds and it looks fine so it's good to go I say.
comment:13 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #291 from mantidproject/11000_cmake_2_8_12
Move to cmake 2.8.12
Full changeset: f67b7649ce748d170b3cee3100f8fc0214a432f8
comment:14 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11839