Ticket #11009 (closed: fixed)
IDA CC: Allow flat geometry on non-Fortran platforms
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Harry Jeffery |
Description
The F2Py test is done when importing the module rather than where the actual F2Py parts are, preventing flat plate corrections being done on Linux.
The check should be moved to where F2Py is actually used (e.g. here: https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Inelastic/IndirectAbsCor.py#L166)
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Only check for F2Py is it is actually needed
Refs #11009
Changeset: af6f086195f8546fa98a341295ffef8ef833969b
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #173.
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:5 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #173 from mantidproject/11009_ida_calccor_allow_flat_plate_cross_platform
Only check for F2Py is it is actually needed for indirect corrections
Full changeset: b76295e27782199234829267dd5291fafd85030b
comment:6 Changed 6 years ago by Harry Jeffery
Merge pull request #173 from mantidproject/11009_ida_calccor_allow_flat_plate_cross_platform
Only check for F2Py is it is actually needed for indirect corrections
Full changeset: b76295e27782199234829267dd5291fafd85030b