Ticket #11045 (closed: fixed)
BugFix: Deleting Peaks Workspaces in the Splatterplot View in the VSI
| Reported by: | Anton Piccardo-Selg | Owned by: | Anton Piccardo-Selg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | GUI | Keywords: | VATES |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
When deleting and readding a Peaks Workspace to the Splatterplot view in the VSI, Mantid crashes.
To reproduce:
- Load an MDEvent workspace into the VSI and switch to the Splatterplot view
- Load a Peaks Workpace into the VSI
- Delete the Peaks Workpace in the pipeline browser
- Add the Peaks Workspace again
Mantid should crash at this point.
The SplatterPlot keeps track of Peaks sources, when they are added, but does not keep track of their deletion when they are being deleted from the pipeline browser.
Attachments
Change History
comment:2 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from assigned to inprogress
Refs #11045 Add destroyed listener for peak sources
Changeset: 170a32c8ac1b8991b568512cd56fb7e5c04bb576
comment:3 Changed 6 years ago by Anton Piccardo-Selg
Refs #11045 Fix for crash with deleted peaks workspace
Changeset: 692b04bb19d4cedde8fc01d5e8f19d5170b2768d
comment:4 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #353.
comment:6 Changed 6 years ago by Raquel Alvarez
- Status changed from verify to verifying
- Tester set to Raquel Alvarez
comment:7 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from verifying to verify
- Tester Raquel Alvarez deleted
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:10 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:11 Changed 6 years ago by Owen Arnold
Code reviewed and working ok now.
comment:12 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge pull request #353 from mantidproject/bugfix/11045_fix_crash_when_deleting_peaks_ws_in_splatterplot
Fix crash when reloading a deleted peaks workspace in splatterplot mode in the VSI
Full changeset: d5a6a71bd0c9c4d130384556c67f0ea047715044
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11884
