Failure in PoldiPeakSearchTest under Windows debug

[Martyn Gigg]

The MSVC debugger is giving an out of bounds error for the PoldiPeakSearch - ​http://builds.mantidproject.org/view/Develop%20Builds/job/develop_clean_win7_debug/lastCompletedBuild/console

The problem seems to be with line 257 of PoldiPeakSearch.cpp:

MantidVec::const_iterator nextIntensity = peakPosition + 1;
  while (*nextIntensity > halfPeakIntensity) {
    nextIntensity += 1;
  }

The debugger says that during the testGetPeakCoordinates method the nextIntensity iterator goes past the end of the vector. I have attached a screenshot of debugger with some information about the current peak position values if that is helpful.

[Michael Wedel]

Weird, I seem to remember this from before. This happens when there is no intensity smaller than MAX/2 "to the right" of the peak. I will add a check for the border for these cases.

[Michael Wedel]

Refs #11065. Adding a check for vector boundary for fwhm-estimate

Changeset: 38e05433df51b4c85e2d03b4d61d2f7ffb9be878

[Michael Wedel]

This is being verified as ​pull request #208.

[Michael Wedel]

Testing information The branch has been merged into develop. Please make sure that PoldiPeakSearchTest is passing in the debug-build.

[Martyn Gigg]

This looks fine now.

[Martyn Gigg]

Merge pull request #208 from mantidproject/11065_fix_poldi_peak_search_array_bounds

Failure in PoldiPeakSearchTest under Windows debug

Full changeset: ​07967d08a5b7a1607a164aa6710b8bf3bca67496

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​11904