Refactor ICAT interface calls to use InternetHelper

[Nick Draper]

The ICAT classes use poco net classes directly, move them over to using the InternetHelper class

[Nick Draper]

Find all "HTTPSClientSession", Subfolders, Keep modified files open, Find Results 1, Entire Solution, ""
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogDownloadDataFiles.cpp(13):#include <Poco/Net/HTTPSClientSession.h>
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogDownloadDataFiles.cpp(167):    Poco::Net::HTTPSClientSession session(*socket);
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogDownloadDataFiles.cpp(218):  // created and destroyed by HTTPSClientSession). We avoid that crash by
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogDownloadDataFiles.cpp(220):  // ourselves and passing it to the HTTPSClientSession, which takes ownership.
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogPublish.cpp(13):#include <Poco/Net/HTTPSClientSession.h>
  C:\Mantid\Code\Mantid\Framework\ICat\src\CatalogPublish.cpp(157):    Poco::Net::HTTPSClientSession session(uri.getHost(), uri.getPort(),
  C:\Mantid\Code\Mantid\Framework\Kernel\src\InternetHelper.cpp(12):#include <Poco/Net/HTTPSClientSession.h>
  C:\Mantid\Code\Mantid\Framework\Kernel\src\InternetHelper.cpp(241):    HTTPSClientSession session(uri.getHost(),
  C:\Mantid\Code\Mantid\Framework\Kernel\src\RemoteJobManager.cpp(6):#include <Poco/Net/HTTPSClientSession.h>
  C:\Mantid\Code\Mantid\Framework\Kernel\src\RemoteJobManager.cpp(215):    m_session = new Poco::Net::HTTPSClientSession(
  Matching lines: 10    Matching files: 4    Total files searched: 8135

[Nick Draper]

re #11066 removed two classes using HTTPS classes needs dev testing

Changeset: edcdd0ad1602875fb1bcdea9bea4936fc5cd54f4

[Nick Draper]

re #11066 Dev testing done on windows at ISIS

Changeset: cbaf9928eeaec7971ff81f31bd1d3df7564b019d

[Nick Draper]

Complete other than developer testing of the publish functionality, waiting on ICAT test system, or credentials to allow this.

[Nick Draper]

Moved to R3.5 at the R3.4 code freeze

[Stuart Campbell]

This ticket has been transferred to github issue ​11905