Ticket #11110 (closed: fixed)
fix clang warnings and errors
Reported by: | Steven Hahn | Owned by: | Steven Hahn |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
Both a new compiler warning and error was recently introduced on master.
15:44:20 /Users/builder/jenkins-linode/workspace/master_clean-clang/label/osx-10.9-build/Code/Mantid/Framework/Kernel/src/InternetHelper.cpp:137:35: error: invalid operands to binary expression ('std::ostream' (aka 'basic_ostream<char>') and 'std::ostringstream' (aka 'basic_ostringstream<char>')) 15:44:20 session.sendRequest(*m_request) << m_body;
02:59:12 /Users/builder/jenkins-linode/workspace/master_clean-clang/label/osx-10.9-build/Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSymmetrise.cpp:278:14: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] 02:59:12 if((prop == m_propertiesPreviewSpec?))
Change History
comment:2 Changed 6 years ago by Steven Hahn
- Status changed from new to verify
- Resolution set to fixed
This is being verified as pull request #232.
comment:4 Changed 6 years ago by Steven Hahn
Refs #11110. switch from rdbuf() to str()
Changeset: 0f3df5223605eb54b31933f8516b5b3ada805e4e
comment:6 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to closed
- Tester set to Wenduo Zhou
Merge pull request #232 from mantidproject/feature/11110_fix_clang_error
Fix compiler error and warning on AppleClang
Full changeset: f988bd4cac731a239969cebe8248e9052f1969b9
Refs #11110. Fix compiler error and warning on AppleClang
Changeset: 029132cc2a45889d38f4b220f14fcd63c456c1bc