Ticket #11111 (closed: fixed)
MD files lazy load experiment info
| Reported by: | Ian Bush | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | PatchCandidate |
| Cc: | nick.draper@…, martyn.gigg@… | Blocked By: | #11101 |
| Blocking: | Tester: | Federico M Pouzols |
Description
Once the class described in #11101 is tested and working, then FileBackedExperimentInfo should be used in MDBoxFlatTree::loadExperimentInfos (called by LoadMD), instead of the standard ExperimentInfo class.
Change History
comment:2 Changed 6 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Martyn Gigg
- Milestone changed from Backlog to Release 3.4
comment:3 Changed 6 years ago by Martyn Gigg
- Status changed from assigned to inprogress
Use FileBackedExperimentInfo in LoadMD
Only used in conjunction with the file backend option. Refs #11111
Changeset: d98a7bbbdaeca7071a15b37ccdb1688bb1300694
comment:4 Changed 6 years ago by Martyn Gigg
Use FileBackedExperimentInfo in LoadMD
Only used in conjunction with the file backend option. Refs #11111
Changeset: 3694713ac206cbedd7e85d6d62e6d4713ffef1bc
comment:5 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #327.
comment:8 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:9 Changed 6 years ago by Federico M Pouzols
All looks good, including system tests.
I did a quick non-rigorous comparison using the large 22413_22932_SQW.nxs (~24 GB) file. I'd say that that's more than enough to verify that 'FileBackEnd' does what it is supposed to do:
- With FileBackEnd enabled: 58.72 s to finish a lazy LoadMD. Goes down to 37.84 s once the file is buffered.
- Without: 1579.46 s for a traditional, full load. I was going to stop it as It gets awfully slow when it runs out of RAM on a 16GB machine and starts using swap space.
comment:10 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #327 from mantidproject/11111_loadmd_filebacked_expt_info
Use FileBackedExperimentInfo class in LoadMD
Full changeset: 55aead44f2a3d12e5a04fec773ed548f4c785d81
comment:11 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11950
