Ticket #11112 (closed: fixed)
Generate events filters by various time steps
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | petersonpf@… | Blocked By: | |
Blocking: | Tester: | Federico M Pouzols |
Description
In some case, the user wants to split the events along time with various time steps but not a constant time step that is the only supported format now.
Thus add a new property for various time steps.
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
- Status changed from assigned to inprogress
Refs #11112. Modified the property TimeInterval.
Such that it can take a list of doubles instead of 1.
- modified: ../Mantid/Framework/Algorithms/src/GenerateEventsFilter.cpp
- modified: ../Mantid/Framework/Algorithms/test/GenerateEventsFilterTest.h
- modified: ../Mantid/Framework/Kernel/src/InternetHelper.cpp:
the cast of osstringstream to osstream on mac osx. Modify it only to make the compiling pass.
Changeset: 6aa6a5c70a2659597170af3d37de43d41463f625
comment:3 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #233.
comment:4 Changed 6 years ago by Wenduo Zhou
Refs #11112. Implemented the new feature and unit test.
Changeset: 813315ec985e7b5d25a5b36db03018239585e79c
comment:5 Changed 6 years ago by Wenduo Zhou
Refs #11112. Improved documentation.
Changeset: 83c603965a3b19e30897ae27f942f668d7f4909d
comment:6 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to reopened
- Resolution fixed deleted
comment:7 Changed 6 years ago by Wenduo Zhou
For tester
- Check whether any system test and unit test gets failed due to the change of input property 'TimeInterval';
- Find an event Nexus file, such as PG3_9829_event.nxs in system test. Then run GenerateEventFilters by setting TimeInterval to a few numbers for various lengths of splitters. Then check whether the output SplitterWorkspace has the correct output. You may also run FilterEvents from the result with option 'SplitLogs' on. It is easy to check the sample logs such that they are split as you expect.
comment:8 Changed 6 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Cleaned up some issues in doc. Refs #11112.
Changeset: 978f39c703a628de2bcde1966aeade2ed07547aa
comment:9 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Wenduo Zhou
Fixes issue #11112(http://mantidproject.org/mantid/ticket/11112)
The changes is to enable GenerateEventsFilter to generate splitters with various time intervals. Besides the documentation of this algorithm and unit tests are updated for the new feature.
For tester
- Check whether any system test and unit test gets failed due to the change of input property 'TimeInterval';
- Find an event Nexus file, such as PG3_9829_event.nxs in system test. Then run GenerateEventFilters by setting TimeInterval to a few numbers for various lengths of splitters. Then check whether the output SplitterWorkspace has the correct output. You may also run FilterEvents from the result with option 'SplitLogs' on. It is easy to check the sample logs such that they are split as you expect.
comment:11 Changed 6 years ago by Wenduo Zhou
Fixed a conflict. Refs #11112.
Changeset: 9cc34613348c555adf21d68526ce79d014c93d1f
comment:12 Changed 6 years ago by Martyn Gigg
Could you update the pull request title remove the ticket number, following the guidelines [here](http://www.mantidproject.org/Git_Workflow).
comment:13 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:14 Changed 6 years ago by Federico M Pouzols
Not really part of this ticket, but very related, I was checking the wiki page on event filtering (http://www.mantidproject.org/EventFiltering) and I noticed that there are many outdated links. It would be a good idea if someone familiar with this would have a look at it and bring it up to date.
comment:15 Changed 6 years ago by Federico M Pouzols
It all looks good to me, and well documented. GenerateEventFilters and FilterEvents behave well. Unit and system tests pass.
comment:16 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #233 from mantidproject/feature/11112_gen_various_timestep_filter
Modified the property TimeInterval of GenerateEventsFilter.
Full changeset: 415b770e08ed2820a1a1bda7d6993de8fe6a85fc
comment:17 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11951