Ticket #11122 (closed: fixed)
Add unit tests for the remote algorithms
Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | #10591 | |
Blocking: | #9277, #11064, #11126 | Tester: | Karl Palmen |
Description (last modified by Federico M Pouzols) (diff)
Before reorganizing code related to the remote algorithms and the remote job manager (see #11064), add tests for the following algorithms which have been in Framework/RemoteAlgorithms for some time:
- AbortRemoteJob
- Authenticate
- DownloadRemoteFile
- QueryAllRemoteJobs
- QueryRemoteFile
- QueryRemoteJob
- StartRemoteTransaction
- StopRemoteTransaction
- SubmitRemoteJob
- UploadRemoteFile
Also, there should be a basic test for this dependency:
- SimpleJSON
Change History
comment:3 Changed 6 years ago by Federico M Pouzols
- Blocked By 10591 added
#10591 added a test for a new remote algorithm. To prevent conflicts it would be best to have that one in master before working on this one.
comment:4 Changed 6 years ago by Federico M Pouzols
- Blocking 9277 added
(In #9277) Added a few blocking tickets (needed to make the RemoteJobManager generic to different web services and underlying job control mechanisms).
comment:5 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
added new files for individual remote algs, re #11122
Changeset: 9433992f178a25ffd155bb586b37b6eea3e6432e
comment:7 Changed 6 years ago by Federico Montesino Pouzols
add basis unit test for SimpleJSON, re #11122
Changeset: e1a83032e521e5d1ff25cbd9efcf96f36cd933dd
comment:8 Changed 6 years ago by Federico Montesino Pouzols
add basic unit test for prev existing remote algs, re #11122
Changeset: 634b4bd65a247994124fee1458b24dc0f95953db
comment:9 Changed 6 years ago by Federico Montesino Pouzols
restore facility, re #11122
Changeset: c9815d6f683ec378340ec70880d1e467e6abd68b
comment:10 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #389.
comment:11 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:12 Changed 6 years ago by Federico Montesino Pouzols
It currently fails to compile on win7 cause the algorithms were missing the dll export.
comment:13 Changed 6 years ago by Federico Montesino Pouzols
add dll export define to compile remote algs on win7, re #11122
Changeset: 544101b751dfc1d6e0bdc679e8f077104d8cbf22
comment:14 Changed 6 years ago by Federico Montesino Pouzols
add dll export also in SimpleJSON for its test win7, re #11122
Changeset: d0ef5d6cfec9a4894f6befcbb25e0840982c71e2
comment:15 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, retest this please
comment:16 Changed 6 years ago by Karl Palmen
I saw that there are many tests with name containing 'wronProperties'. I think 'wrongProperties' was intended.
comment:17 Changed 6 years ago by Federico Montesino Pouzols
fix typo in some test names, re #11122
Changeset: 809dfcd5dc0dc3b933076c8731cc955a6a6634c4
comment:18 Changed 6 years ago by Federico Montesino Pouzols
Yes, you're right. Thanks for spotting that. Copy&paste propagated the typo to several tests. It should be ok now.
comment:19 Changed 6 years ago by Federico Montesino Pouzols
fix compiler warnings and better cast checks, re #11122
Changeset: a2d0bfb667e7e070352a2c2de344dca2ac11ea24
comment:20 Changed 6 years ago by Federico Montesino Pouzols
fix compiler warning on win7, better checks, re #11122
Changeset: 9c111d26b6f1b4fc33071d2251f3c60834789cf5
comment:21 Changed 6 years ago by Federico Montesino Pouzols
fix compiler warning on win7, re #11122
Changeset: 5cde22537eee1cb984a1e205d9147feef4ccf54c
comment:22 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, retest this please
comment:23 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, retest this please
comment:24 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, test this please
comment:25 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, test this please
comment:26 Changed 6 years ago by Federico Montesino Pouzols
Jenkins, test this please
comment:27 Changed 6 years ago by Federico Montesino Pouzols
clang-format it, re #11122
Changeset: d6d8e734863b26e370c2f6b87ee44e8f104457cb
comment:28 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge pull request #389 from mantidproject/11122_unit_tests_for_existing_remote_algorithms
Add unit tests for existing remote algorithms (+ SimpleJSON)
Full changeset: 0ed77122f8e610782ecd4aff54a75960b3b5750f
comment:29 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:30 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11961