Ticket #11123 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add IRemoteJobManager interface

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #9277, #11064, #11124, #11126, #11392 Tester: Roman Tolchenov

Description (last modified by Federico M Pouzols) (diff)

Follow the design/diagram on slide 19 of ​https://github.com/mantidproject/documents/blob/master/Presentations/SOS18/Mantid%20HPC%20Challenges.pptx

It will have pure virtual methods like Abort(), Authenticate(), DownloadFile(), SubmitJob(), etc.

This is needed to then add the class RemoteJobManagerFactory. After that, the classes MantidWSAPIJobManager, LSFJobManager, SCARFLSFJobManager etc. can be added that extend IRemoteJobManager.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Blocking 11124 added

comment:2 Changed 6 years ago by Federico M Pouzols

  • Blocking 11126 added

comment:3 Changed 6 years ago by Federico M Pouzols

  • Blocking 9277 added

(In #9277) Added a few blocking tickets (needed to make the RemoteJobManager generic to different web services and underlying job control mechanisms).

comment:4 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:6 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

Added IRemoteJobManager interface, re #11123

Changeset: 38fde9f9ea800a9c0a9c1d37dd66379c8f458d08

comment:7 Changed 6 years ago by Federico Montesino Pouzols

Make the clear-cut const methods const, re #11123

Changeset: 5bbc66e0524630201da57955e446e3efef6cd995

comment:8 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #398.

comment:9 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:10 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:11 Changed 6 years ago by Federico Montesino Pouzols

more specific header define, re #11123

Changeset: d3e3c0d10cb51fdcea89d6c4e41b150b5356239d

comment:12 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:13 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:14 Changed 6 years ago by Federico M Pouzols

  • Blocking 11392 added

comment:15 Changed 6 years ago by Martyn Gigg

Most of our interface classes are in API, is there a reason this is in Kernel?

comment:16 Changed 6 years ago by Federico Montesino Pouzols

I guess that I just put it in the same place where the current RemoteJobManager class lives. But yes, it doesn't make much sense to me, and actually the RemoteJobManagerFactory that comes in a follow-up ticket is inside API. So I'll move this interface into API.

comment:17 Changed 6 years ago by Federico Montesino Pouzols

add constness of auth method, and a std namespace, re #11123

Changeset: db47165db5867b841dee0d610ef16e0267d7bd35

comment:18 Changed 6 years ago by Federico Montesino Pouzols

move the IRemoteJobManager interface Kernel->API, re #11123

Changeset: 4d7dae89acff799302f3b338306f47fec34fecce

comment:19 Changed 6 years ago by Martyn Gigg

Kernel/API are a somewhat arbitrary split so I just wondered on the reason. Thanks

comment:20 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:21 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:22 Changed 6 years ago by Federico Montesino Pouzols

Seemingly unrelated and random system test failue.. Jenkins, retest this please

comment:23 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:24 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:25 Changed 6 years ago by Federico Montesino Pouzols

Jenkins could you retest this please?

comment:26 Changed 6 years ago by Federico Montesino Pouzols

and update namespace, re #11123

Changeset: a905bd1afa82313890c28efe03ddc9504c38d6cd

comment:27 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:28 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:29 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:30 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:31 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:32 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:33 Changed 6 years ago by Federico Montesino Pouzols

use DateAndTime in job info struct, re #11123

Changeset: f9c905e9c126e2885cc96fba7c7604f9dd010f81

comment:34 Changed 6 years ago by Federico Montesino Pouzols

fix comments, re #11123

Changeset: 9b111262379ee6d7a4899b3a0fe7d4190a4addbe

comment:35 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:36 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:37 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:38 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:39 Changed 6 years ago by Federico Montesino Pouzols

Jenkins... retest this please

comment:40 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #398 from mantidproject/11123_add_IRemoteJobManager

Add IRemoteJobManager interface

Full changeset: ​581d861d25e8765ebb6bc6a3fc84ed8461c93eab

comment:41 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:42 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11962

Note: See TracTickets for help on using tickets.