Ticket #398 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Cylindrical angles are not calculated correctly for grouped detectors

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 15
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

If you group two detectors (or banks of detectors) that are symmetrically on opposite sides of the beamline a call to detectorTwoTheta gives 0, which is not what we want! This is because they are averaged in cartesian coordinates before conversion to polars.

Also, the view detectors option in qtiplot show the absolute r,theta,phi values when it would be better to show them relative to the sample position (in most cases the sample is at the origin, but not always).

Change History

comment:1 Changed 12 years ago by Russell Taylor

(In [1963]) Changed way in which l2 & 2theta is calculated for grouped detectors. Re #398.

comment:2 Changed 12 years ago by Russell Taylor

(In [1964]) Fix tests. Re #398.

comment:3 Changed 12 years ago by Russell Taylor

(In [1971]) Change detectors table to show position relative to the sample and to give correct values for grouped detectors. Re #398.

comment:4 Changed 12 years ago by Russell Taylor

  • Status changed from new to closed
  • Resolution set to fixed

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1246

Note: See TracTickets for help on using tickets.