Ticket #11124 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add class RemoteJobManagerFactory

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By: #11123
Blocking: #9277, #11064, #11126, #11373, #11392 Tester: abuts

Description (last modified by Federico M Pouzols) (diff)

And/or clarify the role of FacilityInfo::getRemoteJobManager. EDIT: Conclusion about this is: at some point it will be removed (#11373, after or with #11392). It is being replaced with the RemoteJobManagerFactory.

In the remote algorithms, RemoteJobManager objects are being created via ConfigService::Instance().getFacility().getRemoteJobManager(name)

Follow the design/diagram on slide 19 of ​https://github.com/mantidproject/documents/blob/master/Presentations/SOS18/Mantid%20HPC%20Challenges.pptx

This new factory should behave like other factories in Mantid. It provides a Create(name) method that returns an IRemoteJobManager object (as a shared pointer).

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Blocking 11126 added

comment:2 Changed 6 years ago by Federico M Pouzols

  • Blocking 9277 added

(In #9277) Added a few blocking tickets (needed to make the RemoteJobManager generic to different web services and underlying job control mechanisms).

comment:3 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Federico M Pouzols

  • Blocking 11373 added

comment:5 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

new class ComputeResourceInfo, and added into FacilityInfo, re #11124

Changeset: 284b7d94dc5ad3e9653123514d7ad0dbd5ac01a3

comment:6 Changed 6 years ago by Federico Montesino Pouzols

new RemoteJobManagerFactory class, re #11124

Changeset: 873645b9e6421570923358e031d5dfcdb4d8253c

comment:7 Changed 6 years ago by Federico Montesino Pouzols

finalised ComputeResourceInfo test, re #11124

Changeset: a2f0f36675760a0d9a435803d48fe0b0ffcc6195

comment:8 Changed 6 years ago by Federico Montesino Pouzols

remotejobmanager factory test seems done for now, re #11124

Changeset: 21e06f2fddd2ef8178ab25878f954ada32051bf9

comment:9 Changed 6 years ago by Federico Montesino Pouzols

re-use boost shared_ptr var, re #11124

Changeset: e125fd62967187b7d0fa943b4b671ed0a3f5d9e6

comment:10 Changed 6 years ago by Federico M Pouzols

  • Blocking 11392 added

comment:11 Changed 6 years ago by Federico Montesino Pouzols

re-use boost shared_ptr var, re #11124

Changeset: e125fd62967187b7d0fa943b4b671ed0a3f5d9e6

comment:12 Changed 6 years ago by Federico Montesino Pouzols

IRemoteJobManager is now in API not Kernel, re #11124

Changeset: 23472d9369024949b8d8a83b169990b90733c73d

comment:13 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:14 Changed 6 years ago by Federico Montesino Pouzols

fixes to comments and doxygen tags, re #11124

Changeset: 994a6f14cd6346ce4101a330e6428f887dc52d60

comment:15 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #469.

comment:16 Changed 6 years ago by Federico Montesino Pouzols

fix forward delcaration on windoze, re #11124

Changeset: fb4ac6c4f0a426e4ffe9715f514e9a429a78f961

comment:17 Changed 6 years ago by Federico Montesino Pouzols

fix doxygen typo in IRemoteJobManager, re #11124 (and 11123)

Changeset: 273fa605b5cdd6b130ff731c68862a452cd0418f

comment:18 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:19 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:20 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:21 Changed 6 years ago by Alex Buts

Looks fine to me as the starting point.

As the next step I would add a local host job manager as generic manager to all facilities. As I understand, we are talking about Mantid jobs so this would be useful on its own and priceless for testing.

comment:22 Changed 6 years ago by abuts

  • Status changed from verify to closed
  • Tester set to abuts

Merge pull request #469 from mantidproject/11124_add_class_RemoteJobManagerFactory

Add class RemoteJobManagerFactory (+ ComputeResourceInfo)

Full changeset: ​29d1a3b284775a11d7f0c6745d1f11eb02fbac8c

comment:23 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11963

Note: See TracTickets for help on using tickets.