Ticket #11125 (closed: fixed)
Ability to copy detector mapping form one workspace to another
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | spencer.howells@…, Alex.Buts@… | Blocked By: | |
Blocking: | Tester: | Raquel |
Description (last modified by Dan Nixon) (diff)
Currently there is no simple way to copy the detector mapping from on workspace to another, this functionality is somewhat present in SpectrumDetectorMapping and should be wrapped in an algorithm.
Note the intended use for this algorithm is to be part of Python workflow algorithms, it is not something a user would usually do directly on workspaces.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Initial version of CopyDetectorMapping algorithm
Refs #11125
Changeset: 98a23b707ef9637e62c857015cc95b1cdba80022
comment:3 Changed 6 years ago by Dan Nixon
Add test and validation for equal histogram counts
Refs #11125
Changeset: 8858b6255a61035d9428e2a32f38130cb1e39548
comment:4 Changed 6 years ago by Dan Nixon
Add documentation for CopyDetectorMapping
Refs #11125
Changeset: 6e70159bddb2d4249161a63e59a0bb91977c5eb7
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #249.
comment:7 Changed 6 years ago by Dan Nixon
Set default value of member variables correctly
Refs #11125
Changeset: 6645db651a4c26c89bbbc66a435d615b4ab09716
comment:8 Changed 6 years ago by Raquel
- Status changed from verify to verifying
- Tester set to Raquel
comment:9 Changed 6 years ago by Raquel
Code and unit test look nice, well documented as well. I have just noticed an issue: when dealing with workspace groups Mantid crashes. This is confusing when you only have one workspace group loaded in Mantid and then you execute the algorithm, as it crashes without information. Given the purpose of the algorithm I may not make much sense trying to use workspace groups, but an error message would be useful.
comment:10 Changed 6 years ago by Dan Nixon
Understandably, it should only be used with matrix workspaces. Will change the properties to workspace properties instead.
comment:11 Changed 6 years ago by Dan Nixon
comment:13 Changed 6 years ago by Dan Nixon
comment:14 Changed 6 years ago by Alex Buts
- Cc Alex.Buts@… added
What is the difference between this and CopyInstrumentParameters & ApplyCalibration. How do they work together?
comment:15 Changed 6 years ago by Dan Nixon
comment:16 Changed 6 years ago by Dan Nixon
Add validation to workspaces to ensure MatrixWorkspaces are used
Refs #11125
Changeset: dac7b690910a39ba626538001b0772392a35680e
comment:17 Changed 6 years ago by Raquel Alvarez Banos
There are a couple of errors I am getting when testing this ticket:
- Load MUSR00015189 (this is a workspace group)
- Execute CopyDetectorMapping, Mantid crashes
Also:
- Load a single workspace (I tried ARCS_2963.nxs)
- Load a workspace group (for instance MUSR00015189)
- Execute CopyDetectorMapping
- Mantid crashes if WorspaceToMatch=ARCS_2963 and WorkspaceToRemap=MUSR00015189
comment:18 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 11125_copy_detector_mapping_algorithm
Refs #11125
Changeset: 96d4cee89579dbe87932af4f8e037803bbf7ce54
comment:19 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:20 Changed 6 years ago by Dan Nixon
comment:21 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:22 Changed 6 years ago by Raquel Alvarez
- Status changed from verifying to closed
Merge pull request #249 from mantidproject/11125_copy_detector_mapping_algorithm
Copy spectra-detector mapping algorithm
Full changeset: ff99c4e40b43540fd889a79aad61d21586533827
comment:23 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11964