Ticket #11158 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDR: hide/show tabs based on facility

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: #11157, #11162, #11163 Tester: Stuart Campbell

Description

The current ET, calibration and diagnostics tabs should be renamed to something ISIS specific and logic put in place to have the UI show and hide tabs based on the current default facility.

Currently:

  • ISIS: all tabs shown
  • Anywhere else: hide ET, calib. and diag.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Renamed ISIS specific interfaces

Refs #11158

Changeset: 0f9090b8d6be523531cf4ff7c7b6b0415f5f3b6e

comment:3 Changed 6 years ago by Dan Nixon

For the sake of generating the documentation this will likely have to load all the interfaces and just hide and block signals to and from those that are not needed.

comment:4 Changed 6 years ago by Dan Nixon

  • Blocked By 11162 added

comment:5 Changed 6 years ago by Dan Nixon

  • Blocked By 11162 removed

comment:6 Changed 6 years ago by Dan Nixon

Enable/disable tabs as needed, update instrument selector

Need to actually remove the tab

Refs #11158

Changeset: b5361fa704ff9695fce04398c1edbcdfe1c015b5

comment:7 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11158_indirect_idr_facility_based_tabs_logic

For the sake of ignoring the Poco header

Refs #11158

Changeset: fef932f1c4313ce4d0aa6230eaab176778fa0156

comment:8 Changed 6 years ago by Dan Nixon

To test: see PR.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:9 Changed 6 years ago by Dan Nixon

Added proper code for tab switching

Refs #11158

Changeset: 9f8920fb9bfd96b5639e43a86ef56f1201797ef7

comment:10 Changed 6 years ago by Dan Nixon

Correct documentation for changes

Refs #11158

Changeset: 1df87940e0fb3519fc3db60993ec5818c2962884

comment:11 Changed 6 years ago by Dan Nixon

Fix some UI issues with documentation

Having the tabs less than 500px wide would be useless most of the time anyway.

Refs #11158

Changeset: 05fd3692ab825c6c6e975b33378cc35b19f9ac50

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #300.

comment:13 Changed 6 years ago by Dan Nixon

  • Blocking 11162 added

comment:14 Changed 6 years ago by Dan Nixon

  • Blocking 11163 added

comment:15 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11158_indirect_idr_facility_based_tabs_logic

Refs #11158

Changeset: 7ebe6aab2943f726eccb016198a6669bc7948201

comment:16 Changed 6 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:17 Changed 6 years ago by Dan Nixon

Fix reported build issues on Windows

Refs #11158

Changeset: a2a8f749ca7052917b4a447009dd0c34d7badf1b

comment:18 Changed 6 years ago by Dan Nixon

Merge branch '11158_indirect_idr_facility_based_tabs_logic' into 11162_ill_idr_et_tab

Refs #11158

Changeset: 054931b15f19d4c142dd834dab3b37f52773d8d1

comment:19 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:20 Changed 6 years ago by abuts

  • Status changed from verifying to closed

Merge pull request #300 from mantidproject/11158_indirect_idr_facility_based_tabs_logic

Indirect IDR facility based tab display logic

Full changeset: ​aea735910c9fb941ed1b6917f3d1615661f02833

comment:21 Changed 6 years ago by Dan Nixon

Merge branch '11158_indirect_idr_facility_based_tabs_logic' into 11162_ill_idr_et_tab

Refs #11158

Full changeset: ​054931b15f19d4c142dd834dab3b37f52773d8d1

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11997

Note: See TracTickets for help on using tickets.