Ticket #11163 (closed: fixed)
IDR: Add ILL calibration tab
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.5 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | #11158 | |
Blocking: | #11157 | Tester: | Federico Montesino Pouzols |
Description (last modified by Dan Nixon) (diff)
Add a calibration tab for ILL runs.
In Spencer's words:
For the new ILL Calib - it reads & groups as in ET and then integrates etc.
Change History
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Add skeleton tab for ILL calibration
Refs #11163
Changeset: 5d0451184f5c6b5061c74c3144c05264f1ada7e6
comment:5 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 11163_ill_calibration_tab
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/CMakeLists.txt Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectDataReduction.cpp
Refs #11163
Changeset: e672a9d2d23c748c4dc7b0b324e3485e5871e4f5
comment:7 Changed 5 years ago by Dan Nixon
Merge branch 'master' into 11163_ill_calibration_tab
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/CMakeLists.txt
Refs #11163
Changeset: 04b34da73c5b25c6318027fde92f7adb8f33e425
comment:8 Changed 5 years ago by Dan Nixon
Initial version of ILL calibration algorithm
Refs #11163
Changeset: 2f2846cebbee05c5056fab2cfa1a63e919f62e55
comment:9 Changed 5 years ago by Dan Nixon
Handle mirror mode Refs #11163
Changeset: 6094b44e84ad40688f259577014faf3681e8bc6a
comment:10 Changed 5 years ago by Dan Nixon
comment:11 Changed 5 years ago by Dan Nixon
comment:12 Changed 5 years ago by Dan Nixon
comment:13 Changed 5 years ago by Dan Nixon
comment:14 Changed 5 years ago by Dan Nixon
comment:15 Changed 5 years ago by Dan Nixon
comment:16 Changed 5 years ago by Dan Nixon
Add logic to have peak range derived from resolution
Refs #11163
Changeset: 7808f4eda669636e3895527eae5449c273c5b14d
comment:17 Changed 5 years ago by Dan Nixon
Fix Numpy error Refs #11163
Changeset: 300a8aeafc24cfaf4c74a441d3c7037e48fa0740
comment:18 Changed 5 years ago by Dan Nixon
comment:19 Changed 5 years ago by Dan Nixon
comment:20 Changed 5 years ago by Dan Nixon
Add calibration workspace to reduction algo
Refs #11163
Changeset: f9aaff02d8b65c8eed70a4b7237fdbebfcdf016b
comment:21 Changed 5 years ago by Dan Nixon
comment:22 Changed 5 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #673.
comment:23 Changed 5 years ago by Dan Nixon
Merge branch 'master' into 11163_ill_calibration_tab
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Refs #11163
Changeset: ada38b7b74c4bebefd354e8bbef2ade6ba82dc20
comment:24 Changed 5 years ago by Dan Nixon
Merge branch 'master' into 11163_ill_calibration_tab
Conflicts:
Code/Mantid/instrument/IN16B_silicon_111_Parameters.xml
Refs #11163
Changeset: 70a88d110cc93adb30a515f3a3a842817b4d618e
comment:25 Changed 5 years ago by Dan Nixon
Use mapping file in calib (since it is used in ET)
Refs #11163
Changeset: fd7b2703d79fb157a10acee5dbf344cf9581d418
comment:26 Changed 5 years ago by Dan Nixon
comment:27 Changed 5 years ago by Dan Nixon
comment:28 Changed 5 years ago by Dan Nixon
Add a worflow diagram for calib algorithm
Refs #11163
Changeset: 72de01379e1f6ee476c6a8e75a16aa945f35a67c
comment:29 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:30 Changed 5 years ago by Federico Montesino Pouzols
Looks good, it comes with tests and a workflow diagram, and in the new GUI tabs all the options seem to work corerctly.
I only noticed that if I select "Reflection"=>"311" I get errors complaining that IN16B_silicon_311_Parameters.xml is not found. I'd say there's no issue with this If the file is going to be added or it just happens that some users have it, but otherwise I'd disable it if there are updates/additions following.
comment:31 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #673 from mantidproject/11163_ill_calibration_tab
ILL calibration tab
Full changeset: 2a8b4942d513959c4a3e826229e96d75115f0523
comment:32 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12002