Ticket #11167 (closed: fixed)
IDA: fit result is not plotted as expected
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | |
Blocking: | Tester: | Federico M Pouzols |
Description
In MSDFit, FuryFit and ConvFit only the result of a single fit is plotted, if a workspace from a sequential fit is available then this should be plotted when switching spectrum.
Attachments
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Summary changed from IDR: fit result is not plotted as expected to IDA: fit result is not plotted as expected
comment:4 Changed 6 years ago by Dan Nixon
Add proper plotting in ConvFit UI for fit
Refs #11167
Changeset: ddcf419742bee1a91d2a712b38dff566e23f354e
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #297.
comment:9 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 11167_fix_ida_preview_plotting
Refs #11167
Changeset: 23e7678b90b2185c4a856814e3194cc3a56c8c0c
comment:10 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:11 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:12 Changed 6 years ago by Federico M Pouzols
This works well.
I tried to stress the 3 preview plots and they seem to behave. I only got into trobule once with ConvFit. After changing the spectrum and plotting/fitting several times, fitting stopped working (flat line result over and over again). But I cannot reproduce it. It might have been a glitch, and anyway it looked more related to fitting than the plot update itself which was working well.
comment:13 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #297 from mantidproject/11167_fix_ida_preview_plotting
Fix IDA preview plotting
Full changeset: 99be2d24fffcd7b0dfea11bef1d43ea7e04d0292
comment:14 Changed 6 years ago by Dan Nixon
@FedeMPouzols I kind of think that is fitting related, I've seen strange things happen every now and again if the peak centre and FWHM parameters are too far out to get a good fit.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12006