Ticket #11239 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IntegrateEllipsoids output does not change after data normalized to monitors

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Vickie Lynch) (diff)

Bug reported by Xiaoping. Tested with this script: 

Load(Filename='TOPAZ_11052_event.nxs', OutputWorkspace='TOPAZ_11052_event', LoadMonitors=True)
NormaliseToMonitor(InputWorkspace='TOPAZ_11052_event', OutputWorkspace='TOPAZ_11052_event_mon', MonitorWorkspace='TOPAZ_11052_event_monitors', IntegrationRangeMin=400, IntegrationRangeMax=16666)
NormaliseByCurrent(InputWorkspace='TOPAZ_11052_event', OutputWorkspace='TOPAZ_11052_event_cur')
ConvertToMD(InputWorkspace='TOPAZ_11052_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', LorentzCorrection=True, OutputWorkspace='TOPAZ_11052_md', MinValues='-25,-25,-25', MaxValues='25,25,25', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=13, MinRecursionDepth=7)
FindPeaksMD(InputWorkspace='TOPAZ_11052_md', PeakDistanceThreshold=0.37680000000000002, MaxPeaks=1000, DensityThresholdFactor=1, OutputWorkspace='TOPAZ_11052_peaks')
FindUBUsingFFT(PeaksWorkspace='TOPAZ_11052_peaks', MinD=3, MaxD=15, Tolerance=0.12)
CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
IndexPeaks(PeaksWorkspace='TOPAZ_11052_peaks', Tolerance=0.12, NumIndexed=789, AverageError=0.025238045855980905)
CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
ShowPossibleCells(PeaksWorkspace='TOPAZ_11052_peaks', BestOnly=False, NumberOfCells=6, AllowPermutations=False)
SelectCellOfType(PeaksWorkspace='TOPAZ_11052_peaks', CellType='Monoclinic', Apply=True, NumIndexed=789, AverageError=0.025238045855980919)
CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event_mon', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks_mon')
IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event_cur', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks_cur')
IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks')

Change History

comment:1 Changed 6 years ago by Vickie Lynch

  • Description modified (diff)

comment:2 Changed 6 years ago by Vickie Lynch

  • Status changed from new to inprogress

Refs #11239 Use weights for events

Changeset: 13b00329a67ecf96b57af56b7517361788a59b70

comment:3 Changed 6 years ago by anonymous

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #382.

comment:4 Changed 6 years ago by anonymous

Fixes trac issue #11239

Tester This is my test for event data: Load(Filename='TOPAZ_11052_event.nxs', OutputWorkspace='TOPAZ_11052_event', LoadMonitors=True) NormaliseToMonitor(InputWorkspace='TOPAZ_11052_event', OutputWorkspace='TOPAZ_11052_event_mon', MonitorWorkspace='TOPAZ_11052_event_monitors', IntegrationRangeMin=400, IntegrationRangeMax=16666) NormaliseByCurrent(InputWorkspace='TOPAZ_11052_event', OutputWorkspace='TOPAZ_11052_event_cur') ConvertToMD(InputWorkspace='TOPAZ_11052_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', LorentzCorrection=True, OutputWorkspace='TOPAZ_11052_md', MinValues='-25,-25,-25', MaxValues='25,25,25', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=13, MinRecursionDepth=7) FindPeaksMD(InputWorkspace='TOPAZ_11052_md', PeakDistanceThreshold=0.37680000000000002, MaxPeaks=1000, DensityThresholdFactor=1, OutputWorkspace='TOPAZ_11052_peaks') FindUBUsingFFT(PeaksWorkspace='TOPAZ_11052_peaks', MinD=3, MaxD=15, Tolerance=0.12) CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) IndexPeaks(PeaksWorkspace='TOPAZ_11052_peaks', Tolerance=0.12, NumIndexed=789, AverageError=0.025238045855980905) CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) ShowPossibleCells(PeaksWorkspace='TOPAZ_11052_peaks', BestOnly=False, NumberOfCells=6, AllowPermutations=False) SelectCellOfType(PeaksWorkspace='TOPAZ_11052_peaks', CellType='Monoclinic', Apply=True, NumIndexed=789, AverageError=0.025238045855980919) CopySample(InputWorkspace='TOPAZ_11052_peaks', OutputWorkspace='TOPAZ_11052_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event_mon', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks_mon') IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event_cur', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks_cur') IntegrateEllipsoids(InputWorkspace='TOPAZ_11052_event', PeaksWorkspace='TOPAZ_11052_peaks', RegionRadius=0.3, OutputWorkspace='TOPAZ_11052_peaks')

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 6 years ago by Owen Arnold

What you are doing looks right, in terms of using the weights for the data event workspaces, and counts for the histogram workspaces. However, for each peak in Q, you also have some kind of weight, always set to 1? I don't understand the purpose of the Pairs that you now pass into ellipseIntegrateEvents. As far as I can tell the first element of the Pair is unused.

​https://github.com/mantidproject/mantid/blob/11239_IntegrateEllipsoids_event_weights/Code/Mantid/Framework/MDEvents/src/IntegrateEllipsoids.cpp#L460

and

​https://github.com/mantidproject/mantid/blob/11239_IntegrateEllipsoids_event_weights/Code/Mantid/Framework/MDEvents/src/IntegrateEllipsoids.cpp#L386

comment:7 Changed 6 years ago by Vickie Lynch

Refs #11239 weight not needed for peak center Q

Changeset: ca1644e7eb92f75784bddf351a53fa2ade87bebf

comment:8 Changed 6 years ago by Owen Arnold

Merge pull request #382 from mantidproject/11239_IntegrateEllipsoids_event_weights

Refs #11239 Use weights for events

Changeset: f0a9b8f5e655f7f271ddcf365561d2fa4215cd55

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #382 from mantidproject/11239_IntegrateEllipsoids_event_weights

Refs #11239 Use weights for events

Full changeset: ​f0a9b8f5e655f7f271ddcf365561d2fa4215cd55

comment:10 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12078

Note: See TracTickets for help on using tickets.