Ticket #11304 (closed: fixed)
CreateMD
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Direct Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8160, #11231 | Tester: | Andrei Savici |
Description (last modified by Owen Arnold) (diff)
This ticket supersedes #8171.
- This will be done as a python algorithm just like CutMD
- Name better follows naming convention for algorithms http://www.mantidproject.org/Mantid_Standards
http://docs.mantidproject.org/nightly/algorithms/CutMD-v1.html. Design for this work is here https://github.com/mantidproject/documents/blob/master/Design/VATES/MantidHorace/syntax-proposal.md
Change History
comment:5 Changed 6 years ago by Owen Arnold
refs #11304. Create new algorithm.
Changeset: f0b9e427288a3b61660b1b9b191840492d744bda
comment:6 Changed 6 years ago by Owen Arnold
refs #11304. Add the ability to merge md workspaces
Changeset: 179652325cbd768d19d024f3e0a40a24d268825d
comment:7 Changed 6 years ago by Owen Arnold
refs #11304. Use MergeMD rather than PlusMD
I actually prefered using PlusMD as it doesn't require that all workspaces are in the ADS. I now need to give them names and put them there.
Changeset: 80d6ce043ad5d7c2f5a7a35fb960288d27f6ad84
comment:8 Changed 6 years ago by Owen Arnold
refs #11304. Remove temporary workspaces
Changeset: 6c369ef9e72d56cc6522f16e045024eb384f3a7a
comment:9 Changed 6 years ago by Owen Arnold
refs #11304. Add documentation
Changeset: 63fddc515dafc1e2229e1f8392412c074fc84f18
comment:10 Changed 6 years ago by Owen Arnold
refs #11304. Improve documentation
Changeset: aa4aa647e6f7b2d31b132de399e8b6c627bc8c7f
comment:11 Changed 6 years ago by Owen Arnold
refs #11304. Use Global alg version for min max.
Changeset: 277e0128bdbbaaa783ec5a6a85edb4a06233f71e
comment:12 Changed 6 years ago by Owen Arnold
refs #11304. Set goniometer angles from arrays.
Changeset: 3eb662f8212f23a94dc932c0a30dc8fa67684b42
comment:13 Changed 6 years ago by Owen Arnold
refs #11304. Add example docs
Also move the test and fix some of the code along the way.
Changeset: 5a1db1294f9c8a33fe9bb4efb8a1ecad9c5fdd07
comment:14 Changed 6 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #509.
comment:15 Changed 6 years ago by Owen Arnold
refs #11304. Fix merge conflict with master.
Merge branch 'master' into 11304_createmd
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Changeset: 1691e8f69571126b299fae6f99d4ade66a1fccdc
comment:16 Changed 6 years ago by Owen Arnold
refs #11304. Remove old file ref
Changeset: 83f31fce46083e09c537c1831f8dd687f3f2e9b1
comment:17 Changed 6 years ago by Owen Arnold
jenkins retest this please
comment:18 Changed 6 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:19 Changed 6 years ago by Owen Arnold
refs #11304. u, v to U, V
Changeset: ed491ad6edeb3677c5e11f9e311148ddfbb2d4b3
comment:20 Changed 6 years ago by Andrei Savici
Things that should be improved:
- One should be able to use group workspaces (pay attention to number of goniometer settings in the validation. make sure you test something like "ws_group1,ws_single, ws_group2" as input)
- for lattice parameters use ArrayLengthValidator
- If I have 30 workspaces, with 30 values of psi, and all other goniometer settings are 0, I should be able to just leave them empty. It is almost implemented, but for now it raises an error. Run the second usage test, ommiting Gl and Gs. It complains about converting Nones to floats
Once 3 is fixed, it can be merged into master. 1 and 2 can be fixed in a different ticket.
comment:21 Changed 6 years ago by Owen Arnold
Revert "refs #11304. u, v to U, V"
Reverting because U implies the U matrix. We'll keep things lower case and fix the test instead.
This reverts commit ed491ad6edeb3677c5e11f9e311148ddfbb2d4b3.
Changeset: 851ba6e85bb8fd3d58366a8697fae5d4cc81c881
comment:22 Changed 6 years ago by Owen Arnold
refs #11304. Fix failing system test.
Changeset: c6ae615e551e2c0e4280fc4e6284db0978d26282
comment:23 Changed 6 years ago by Owen Arnold
refs #11304. Fix issues from testing.
Main issue is around padding of goniometer log inputs. Use zeros rather than None, as Andrei suggests users may want to apply some but not all of the goniometer angles in batch.
Changeset: 8628ddaecf8be7c7d3dab3e8c8f13ad01452b20b
comment:24 Changed 6 years ago by Owen Arnold
refs #11304. system test ignore.
Changeset: 0dc118d9ce24eb28f29d584d67245bc8d2c2a51a
comment:25 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge branch '11304_createmd' of github.com:mantidproject/mantid into 11304_createmd
Full changeset: 59fd2dc40af644bfda788411a40ebf4dc42eb18d
comment:26 Changed 6 years ago by Andrei Savici
Merge pull request #509 from mantidproject/11304_createmd
CreateMD
Full changeset: fb04718168e29edd9201fdab73fbd75b0e2da55a
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12143