Ticket #11305 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix remaning ApplicationWindow Coverity issues

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

A few issues persisted: 1076128, 1076240, 1076241, 1271719, 1076206, 1076166.

They're quick and easy fixes, so let's take care of the low hanging fruit.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1271719

Changeset: 4938df214319396f0478f6d5cd23587c168feb01

comment:3 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1076166

Changeset: 9b31353260850becd7deb10397a982e6b9289d2d

comment:4 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1076206

Changeset: 613bf16c052848646985b033c0fd37807ee5eea0

comment:5 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1076128

Changeset: 2e10a79f5dca80ca051a2851920b7465b435b1eb

comment:6 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1076240

Changeset: d02c2afcc0ca0a70e72af5f614a93c064d335786

comment:7 Changed 6 years ago by Harry Jeffery

Refs #11305 Fix Coverity issue 1076241

Changeset: a5d77886fc9486ed7a037857ba1649c93e5983f3

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #374.

comment:9 Changed 6 years ago by Federico Montesino Pouzols

Related to this, we now seem to have a build with a more picky ccpcheck (1.68) which has found a few more issues in ApplicationWindow: http://builds.mantidproject.org/view/All/job/cppcheck-1.68/34/cppcheckResult/

comment:10 Changed 6 years ago by Harry Jeffery

Jenkins, retest this please.

comment:11 Changed 6 years ago by Harry Jeffery

Jenkins, retest this please.

comment:12 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:13 Changed 6 years ago by Federico Montesino Pouzols

All looks good. A few less remaining coverity issues...

comment:14 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #374 from mantidproject/11305_fix_remaining_application_window_issues

Fix remaining Coverity issues in ApplicationWindow

Full changeset: ae40a6ca4f95612f98d5bfbf2f8c70a3e405240f

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12144

Note: See TracTickets for help on using tickets.