Ticket #11314 (closed: fixed)
Clean up line breaks in SNSLiveEventDataListener
Reported by: | Ross Miller | Owned by: | Ross Miller |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Harry Jeffery |
Description
Some time back, someone ran an automated tool to shorten the lines in the source code to 80 characters. That tool made some less-than-optimal decisions about where to break the lines. Clean up the most awkward line breaks manually.
No code or functionality changes.
Change History
comment:2 Changed 6 years ago by Ross Miller
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #376.
comment:9 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:10 Changed 6 years ago by Harry Jeffery
I've reviewed the changes and only the following hunks touch lines that actually have code on:
- [Hunk 1](https://github.com/mantidproject/mantid/pull/376/files#diff-b22bae527be86fcb9d3d26819e88bd33L66)
- [Hunk 2](https://github.com/mantidproject/mantid/pull/376/files#diff-b22bae527be86fcb9d3d26819e88bd33L143)
- [Hunk 3](https://github.com/mantidproject/mantid/pull/376/files#diff-b22bae527be86fcb9d3d26819e88bd33L156)
- [Hunk 4](https://github.com/mantidproject/mantid/pull/376/files#diff-32fa11a74793b7920dff433681722488L112)
These are all obviously correct (i.e. have no effect), so I'm going to disregard the unrelated build failure and merge.
comment:11 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #376 from mantidproject/11314_clean_up_live_listener_comments
Clean up line breaks
Full changeset: 03dbf266d660c1d7a0548eacdfd3599c13651f79
comment:12 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12153
Clean up line breaks
At some point, an automated tool was used to limit line lengths to 80 characters. This tool made some less-than-optimal choices about where to break the lines. This change cleans that up. No actual code or functionality changes.
Refs #11314
Changeset: b3939b16f41da356e3228054e071f7d8a9e374cc