Ticket #11315 (closed)

Opened 6 years ago

Last modified 5 years ago

Add Live Listener for TOPAZ beamline

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description

Add a new LiveListener implementation for the TOPAZ beamline at SNS.

Note: TOPAZ hasn't been migrated to the ADARA system, so it can't use the standard SNSLiveEventListener class. This listener will use the old DAS data stream (and will thus be considerably less capable than the SNSLiveEventListener).

Change History

comment:1 Changed 6 years ago by Ross Miller

  • Status changed from new to inprogress

First commit for TOPAZ Live Listener

Basic functionality is implemented. No run start/stop yet. Need to have someone familiar with TOPAZ look at the data and make sure I'm not doing something stupid.

Refs #11315

Changeset: bae63c3f23d0a9fd4f22eee772412beb9604f067

comment:2 Changed 5 years ago by Ross Miller

First commit for TOPAZ Live Listener

Basic functionality is implemented. No run start/stop yet. Need to have someone familiar with TOPAZ look at the data and make sure I'm not doing something stupid.

Refs #11315

Changeset: 29996a9f68358d1f623fafab258f409521f79517

comment:3 Changed 5 years ago by Ross Miller

Update comments about invalid pixel warning

Changed the comment about the (commented out) warning for invalid pixel ID's.

Refs #11315

Changeset: 0afb211bfac0a197419c3bb23e40c91e37ffa401

comment:4 Changed 5 years ago by Ross Miller

Cleanups to the TOPAZ live listener code

Some minor cleanups / fixes to the listener: 1) Set a timeout on the data socket so we can stop the thread even if there's no data to receive 2) Make sure all the log messages have newlines at the end (or else they won't ever display in MantidPlot) 3) Delete some cruft that had been #ifdef'd out anyway

Refs #11315

Changeset: c9ba70115f74988adbb767951a6f69bd532b18a9

comment:5 Changed 5 years ago by Ross Miller

Merge branch '11315_TOPAZ_Live_Listener' of github.com:mantidproject/mantid into 11315_TOPAZ_Live_Listener

Conflicts:

Code/Mantid/Framework/LiveData/src/TOPAZLiveEventDataListener.cpp

Refs #11315

Changeset: dec4deeeb7016b86c6157dc7e4bc66fe61901dbd

comment:6 Changed 5 years ago by Ross Miller

Update StartLiveData dialog box

Add code to disable the "Starting Time" gui elements when the TOPAZ listener is selected, because that listener can't select a starting time. (It always starts at at 'Now'.)

Refs #11315

Changeset: 9458f9cb23f416e479c9e6ae228916997c794d7c

comment:7 Changed 5 years ago by Ross Miller

Minor changes to how data is parsed

Change how the TOPAZ listener calculated the indexes in the event list to work around a problem with event_catcher sending out bad data.

Add a log message for cases where we have to discard the events in the packet.

Also, we only need to add to the PROTON_CHARGE time series once per pulse, not once per event.

Refs #11315

Changeset: bc7b6e36892f0655f3b496b95f867082052dff6e

comment:8 Changed 5 years ago by Ross Miller

Update TOPAZ entry in Facilities.xml

Update the "livedata" tag in the TOPAZ entry of Facilities.xml to point at the actual server running event_catcher (instead of my office workstation).

Refs #11315

Changeset: 4e16b796682fb155bfd30e6b58a88171262e4ad2

comment:9 Changed 5 years ago by Pete Peterson

  • Status changed from inprogress to verifying
  • Tester set to Pete Peterson

comment:10 Changed 5 years ago by Ross Miller

  • Status changed from verifying to verify
  • Resolution set to fixed

This is being verified as pull request #713.

comment:11 Changed 5 years ago by Pete Peterson

The OSX one is an actual issue. You increased the number of llvm compiler warnings.

comment:12 Changed 5 years ago by Ross Miller

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:13 Changed 5 years ago by Ross Miller

  • Status changed from reopened to inprogress

Fix Mac build warning

Fix a warning on the Mac about an unused private variable.

Refs #11315

Changeset: 961ec4a0ce1a925e496a62077c1db325796413d6

comment:14 Changed 5 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Tester Pete Peterson deleted

comment:15 Changed 5 years ago by Ross Miller

Fix Win7 build warnings

Was getting 2 warnings about converting from uint64_t to unsigned long. Hopefully, this change fixes them.

Refs #11315

Changeset: fc1fd4f322c792a8f81a27a939f4bf6a16553b37

comment:16 Changed 5 years ago by Ross Miller

Fix another Win7 build warning

Refs #11315

Changeset: 68d9fb9c8c06b29eba38efd4f475fd0355b56b92

comment:17 Changed 5 years ago by anonymous

Just tested at the TOPAZ hutch running ConvertToMD and it works well

comment:18 Changed 5 years ago by Pete Peterson

The windows warning got stale enough for the build details to go away. I merged master into the branch to see the message again (and fix it).

comment:19 Changed 5 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:20 Changed 5 years ago by Pete Peterson

I'm merging based on Vickie's testing.

comment:21 Changed 5 years ago by Ross Miller

  • Status changed from verifying to closed

Merge branch '11315_TOPAZ_Live_Listener' of github.com:mantidproject/mantid into 11315_TOPAZ_Live_Listener

Conflicts:

Code/Mantid/Framework/LiveData/src/TOPAZLiveEventDataListener.cpp

Refs #11315

Full changeset: dec4deeeb7016b86c6157dc7e4bc66fe61901dbd

comment:22 Changed 5 years ago by Pete Peterson

Merge pull request #713 from mantidproject/11315_TOPAZ_Live_Listener

11315 topaz live listener

Full changeset: 0283899a4f8d2ba80c1c3ad3ae0b3436fd60e90d

comment:23 Changed 5 years ago by Peter Peterson

  • Milestone changed from Release 3.5 to Release 3.4

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12154

Note: See TracTickets for help on using tickets.