Ticket #11324 (closed: fixed)
Refactor PlotAsymmetryByLogValue
Reported by: | Raquel Alvarez Banos | Owned by: | Raquel Alvarez Banos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Harry Jeffery |
Description
This ticket is previous to the parallelization that will be addressed in ticket #9215. The aim is to refactor PlotAsymmetryByLogValue in such a way that the main loop (i.e. the loop over different runs) looks like:
for (i=firstRun; i<=lastRun; i++){ loadData(...); analyseData(...); }
Also, improve how information is stored in vectors so they can be safely accessed by different threads.
Change History
comment:2 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Create method to load run and apply corrections and grouping
Changeset: 7fdc4fc1984b7fca37c98497465b2bb6e4529154
comment:3 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 dead time corrections type must be a member variable
Changeset: dccfc7153a7e36aec029e3fcf74b3e3837598b73
comment:4 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Update a couple of comments
Changeset: bd3b8a95bc18207c176114ec78338e5aebd4ec40
comment:5 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Move analysis block to new method
Changeset: 46c9a21eecb119f5fdecd7aa07153e3baf8fd655
comment:6 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Make red and green variables member variables
Changeset: 7a357d241bb142d6ee5b36aa0a29eecadeab1b90
comment:7 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Store run basename and extension in member variable
Changeset: 424f5d997c385c753b33471576c5205d799d80b2
comment:8 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Add member variable to store number of zeros in run name
Changeset: 2a876e249a6befc26d5b9da758894e270adaed81
comment:9 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 The new variable must be int not string
Changeset: d1e68887228811be09542ebac41827b2406acb28
comment:10 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Use member variables in load method
Changeset: a403f16252d77e69f6b20f3c830671c6aa492d34
comment:11 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Fix compilation errors
Changeset: 42de1a94c3b1b94c3c593527d6a56d4bfc174713
comment:12 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Updating description for new/modified methods
Changeset: fdce7e5923b4860d427ab7e1f97f50f670e6cb69
comment:13 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Pass vector index as argument to doAnalysis
Changeset: f714e5b69d614c700301c2536a0cc39068187cae
comment:14 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Use property value to set number of spectra in out workspace
Changeset: 23c48a49b68f90e2fc4dc8815db1b449eaaf5b8d
comment:15 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Resize vectors so they can be accessed using indices
Changeset: fa8c2e0114453c59e15c746f9489677c08120813
comment:16 Changed 6 years ago by Raquel Alvarez
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #385.
comment:17 Changed 6 years ago by Raquel Alvarez
Jenkins, retest this please
comment:18 Changed 6 years ago by Raquel Alvarez
Jenkins, retest this please
comment:19 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:20 Changed 6 years ago by Raquel Alvarez
Jenkins, retest this please
comment:21 Changed 6 years ago by Raquel Alvarez
Jenkins, retest this please
comment:22 Changed 6 years ago by Raquel Alvarez Banos
Re #11324 Remove duplicate if condition
Changeset: 6589b03e24e2ca4229b4dec651f2c0b8d0d4692b
comment:23 Changed 6 years ago by Raquel Alvarez
Yes, you are absolutely right, the second if should not be there, it has been removed now.
comment:24 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #385 from mantidproject/11324_refactor_PlotAsymmetryByLogValue
Refactor PlotAsymmetryByLogValue
Full changeset: 5d3f9b9f3f78825f0a93fcb13eba393d4e4f664b
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12163
Re #11324 Corrections from file will have to be loaded by each thread
Changeset: 28b028e2cdd8e84e1c0c063172d976bee6292db4