Ticket #11353 (closed: fixed)
Tuple syntax for bins in CutMD
| Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Direct Inelastic | Keywords: | VATES |
| Cc: | saviciat@… | Blocked By: | |
| Blocking: | #11354 | Tester: | Owen Arnold |
Description
Andrei is keen on this, and we have it in the design documentation https://github.com/mantidproject/documents/blob/master/Design/VATES/MantidHorace/syntax-proposal.md
In the mantid.simpleapi api only. We want to be able to provide P1Bins to P4Bins as a tuple of tuples. See above for example usage. The wrapper for the algorithm would then unpack the tuples and assign the input to the relevant property based on it's index.
We will look at making CutMD more flexible about slicing 3+ dimensions. At the moment we have P4Bins but no P5bins, but that's not in the scope of this work.
Change History
comment:4 Changed 6 years ago by Harry Jeffery
Refs #11353 Allow tuple syntax for bins in CutMD
Changeset: 7028b81397e6ec07aea4d197cd0badaf4303d501
comment:5 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #396.
comment:6 Changed 6 years ago by Harry Jeffery
Refs #11353 Tweak tuple syntax
- The tuple should be passed to PBins, not P1Bin.
- A list should also work in place of the tuple.
Changeset: 9a82e1f1ed75fc2b3f5bc01353eef3a107c81a7d
comment:7 Changed 6 years ago by Harry Jeffery
Refs #11353 Update CutMD usage example
Changeset: 51408cecb7f0a332198f63338f1bfc260b13812f
comment:8 Changed 6 years ago by Harry Jeffery
Refs #11353 CutMD: Support up to 5 binning dimensions
Changeset: 518d606ab13f7d505a5fbe927dee1fc2ef21cf52
comment:10 Changed 6 years ago by Harry Jeffery
Jenkins, retest this please.
comment:11 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:12 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge pull request #396 from mantidproject/11353_tuple_syntax_for_bins_in_cutmd
Allow tuple syntax for bins in CutMD
Full changeset: 27073d7dbd91e11bf940961eb311c0cbbbe42f1e
comment:13 Changed 6 years ago by Harry Jeffery
Refs #11353 Use specialised CutMD simpleapi implementation
Changeset: 695c8b6b865825751e8f22340ee08acfaec32c22
comment:14 Changed 6 years ago by Harry Jeffery
Refs #11353 Allow a list of workspaces as input to CutMD
Changeset: d260c7317b0ff01dd005860f7df487bff0e34df4
comment:15 Changed 6 years ago by Harry Jeffery
Refs #11353 Tidy up CutMD specialisation
Changeset: 619bbc1475cbde83b521d4edb7dae40276bee559
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12192
