Ticket #11354 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Horace style function handling from scripting for CutMD

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords: VATES-cli
Cc: saviciat@… Blocked By: #11353
Blocking: #11355 Tester: Owen Arnold

Description

https://github.com/mantidproject/documents/blob/master/Design/VATES/MantidHorace/syntax-proposal.md states

data_source could be either an MDEventWorkspace, or iterable collection of workspaces, or, file, or iterative collection of files of type *.sqw, or *.nxs. Consideration could be given to allowing a mix of such input types in the same collection

For now, do not worry about the mixed syntax.

  • Check the type of the input.
  • If it is an iterateable, do what the default behaviour for running WorkspaceGroups through algorithms does. Return the result as a tuple after running n-times.
  • Within each execution, check the type of the input.
  • If type of IMDWorkspace, then pass directly as InputWorkspace
  • If str, check it it's in the ADS, get handle from workspace and then pass that as the InputWorkspace property
  • If str and not in the ADS, try to run Load on it, then take the output and pass through InputWorkspace. Note you should check that this works for files of type SQW, as well as the MDEW format. i.e. check that Load is bound to LoadSQW and LoadMD

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Blocking 11355 added

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Refs #11354 Use specialised CutMD simpleapi implementation

Changeset: 6f660e4ce76a9249a991365a3b9859a97bc63dfd

comment:5 Changed 6 years ago by Harry Jeffery

Refs #11354 Allow a list of workspaces as input to CutMD

Changeset: b347ec9f08ce92609fa36f86baaac94bf28ed1e2

comment:6 Changed 6 years ago by Harry Jeffery

Refs #11354 Tidy up CutMD specialisation

Changeset: 139af5c6b9203154f439df94aafa41024dc827b5

comment:7 Changed 6 years ago by Harry Jeffery

Refs #11354 Return workspace objects, not names

Changeset: b84cfd61b210e26356bd1c56f04cb3572ca2eacd

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #437.

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:10 Changed 6 years ago by Harry Jeffery

Refs #11354 Tidy up CutMD wrapper slightly

Changeset: 14558477194aa9a479eacaa795d10cb28f78edb4

comment:11 Changed 6 years ago by Harry Jeffery

Refs #11354 Improve CutMD documentation

Changeset: cc9e0ac74db58f08a33cb0e8d874ca62edbad8db

comment:12 Changed 6 years ago by Harry Jeffery

Jenkins, retest this please.

comment:13 Changed 6 years ago by Nick Draper

  • Keywords VATES-cli added; VATES removed

comment:14 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #437 from mantidproject/11354_horace_style_for_cutmd

Horace style for cutmd

Full changeset: 3339c377dff094abf0d6fb6b43cef4d88b5f869d

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12193

Note: See TracTickets for help on using tickets.