Ticket #11389 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bayes: hide diff curves when plot is log(y)

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #11365
Blocking: Tester: Michael Wedel

Description

Diff curves have negative Y values, this is not something that should be plotted on a plot with log(y) axis.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Blocked By 11365 added

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Use logy scale for spectrum data

Refs #11389

Changeset: 0d9abe258b0140e2d222964f1d6569500fb8dd49

comment:4 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11389_bayes_hide_diff_curves_when_logy

Refs #11389

Changeset: d23b33af1ca13789116fcc48d897a1de9801e1f4

comment:5 Changed 6 years ago by Dan Nixon

Remove negative Y data from preview plots when log y

Refs #11389

Changeset: 02515661ea737cacafd5cbdb2b427e931a9501c7

comment:6 Changed 6 years ago by Dan Nixon

Get a better default Y scale

Refs #11389

Changeset: 610a2b6655a73199d4cf5a8d92fe07b459f5bc41

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #438.

comment:8 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:9 Changed 6 years ago by Dan Nixon

Fix build issues Refs #11389

Changeset: ee1f3fbd39024b06f011f14943a62b0fd87f4070

comment:10 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:11 Changed 6 years ago by Michael Wedel

  • Status changed from verify to verifying
  • Tester set to Michael Wedel

comment:12 Changed 6 years ago by Michael Wedel

  • Status changed from verifying to closed

Merge pull request #438 from mantidproject/11389_bayes_hide_diff_curves_when_logy

Code looks good and everything works as described, negative values are replaced with the lowest non-negative value in the spectrum. When there are only negative values, nothing is plotted.

Full changeset: fdfa34d59d8e61eecbbd95b8e32397a6cc985980

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12228

Note: See TracTickets for help on using tickets.