Find HDF5 headers in exotic locations

[Federico M Pouzols]

Note: another ticket (#11359) introudced changes related to this. CMake/CommonSetup.cmake now checks for HDF5, but it turns out that a small modification is still needed to actually find the hdf5 include directories (something that only becomes an issue when the headers are not installed in /usr/include or similar).

In our cmake files we are not explicitly looking for HDF5. That is not a big problem, as libnexus depends on it and the hdf5 headers seem to be shipped in /usr/include on all (most) ~nix systems. But it turns out that on debian it is possible to install different flavors/parallel implementations of libhdf5 simultaneously. Depending on the package that you install the headers go to different places that require a specific additional include dir:

• libhdf5-dev -> /usr/include/hdf5/serial/
• libhdf5-mpi-dev libhdf5-openmpi-dev -> /usr/include/hdf5/openmpi/
• libhdf5-mpich-dev -> /usr/include/hdf5/mpich/

So to compile mantid on debian cleanly we need to add HDF5 as a dependency and use FindHDF5 in the cmake files to find the include dir that is needed for libhdf5 (FindHDF5 uses h5c++ etc. to find includes etc.).

At the moment only DataHandling/LoadSassena includes hdf5.h directly. Well, after #11359, there are a couple more source files that include hdf5 headers.

[Federico Montesino Pouzols]

find hdf5 and add its include dirs, re #11388

Changeset: b89b2594a30e10955e4c45ff66bd91b8c7d8e34b

[Martyn Gigg]

Just a note that I have had to do this as part of #11359 as I needed to use hdf5 in another package. It would be worth checking after that is merged that it compiles on Debian still.

[Federico M Pouzols]

Thanks for the note Martyn. Cool to see things fixed. I was about to delete this branch and set this to duplicate but somehow it doesn't compile after #11359 has been merged in. On my linux HDF5_INCLUDE_DIRS is set to /include/hdf5;/include/hdf5/c++;/include/hdf5/hl! I think I figured out why, I think that where it says:

if (${CMAKE_SYSTEM_NAME} MATCHES "Windows" OR OSX_VERSION VERSION_LESS 10.9)

It should say

if (${CMAKE_SYSTEM_NAME} MATCHES "Windows" OR (APPLE AND OSX_VERSION VERSION_LESS 10.9))

Or otherwise it will take the cmake.config that comes with mantid. That would explain why it wasn't working before (I hadn't noticed there was a find_package inside DataHandlin/CMakeLists.txt). I'll get back to this later.

[Martyn Gigg]

Agreed. That change would make sense.

[Federico Montesino Pouzols]

detect apple <10.9 correctly, so FindHDF5 runs elsewhere, re #11388

Changeset: 69635b4f9e239f9176d044e24132a5a410274fe2

[Federico Montesino Pouzols]

This is being verified as ​pull request #429.

[Martyn Gigg]

:+1: This is a sensible change and we might need debian in the not too distant future for the ESS so it is good to get things fixed!

[Martyn Gigg]

Merge pull request #429 from mantidproject/11388_find_hdf5_headers_in_exotic_places

Find HDF5 headers in exotic locations

Full changeset: ​363d25b3d1540650fc6a21b0632685c94ce8c067

[Stuart Campbell]

This ticket has been transferred to github issue ​12227