Ticket #11447 (closed: fixed)
Add a WorkspaceIndex attribute to DiffSphere
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | |
Blocking: | #9198 | Tester: | Roman Tolchenov |
Description
This will allow it to be used with PlotPeakByLogValue to do a sequential fit using the correct Q values directly from the workspace. In turn allowing it to be properly supported in ConvFit.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Add otpion to use WorkspaceIndex for Q value
Refs #11447
Changeset: 3a62ebc4eb912dff6dea2fe85860897ebd46135e
comment:3 Changed 6 years ago by Dan Nixon
Documentation, check Q value list before using it
Refs #11447
Changeset: 83fc46b38805ece37b2705c9d432955e9b4da1c4
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #493.
comment:6 Changed 6 years ago by Dan Nixon
Merge branch '11447_workspaceindex_attribute_in_diffsphere' into 9198_add_diffsphere_support_to_convfit
Refs #11447
Changeset: c63e541fb0b2f665c1c7a211a5ef0024b4d64c7a
comment:7 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:8 Changed 6 years ago by Roman Tolchenov
- There is no unit test for the new functionality.
- Attribute Q should be a double. You should be able to do: getAttribute("Q").asDouble()
comment:9 Changed 6 years ago by Dan Nixon
@mantid-roman Is there any way to have a double attribute that can be left blank? That is the only reason I have not done this.
comment:10 Changed 6 years ago by Roman Tolchenov
You can use either EMPTY_DBL() for Q or EMPTY_INT() for WorkspaceIndex as we do in algorithms.
comment:11 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 11447_workspaceindex_attribute_in_diffsphere
Refs #11447
Changeset: 5ca46e8634cc961afb7d5e4a7cde1b0c19471b06
comment:12 Changed 6 years ago by Dan Nixon
comment:13 Changed 6 years ago by Dan Nixon
comment:14 Changed 6 years ago by Dan Nixon
Update test fro DiffRotDiscreteCircle, clang format
Refs #11447
Changeset: a3867d63d2366c7ebbc2175b0e9d83b1e2e232bd
comment:15 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge pull request #493 from mantidproject/11447_workspaceindex_attribute_in_diffsphere
Add WorkspaceIndex attribute in InelasticDiffSphere and InelasticDiffRotDiscreteCircle
Full changeset: 58d6f7f1f227e0a36a3d3d300f5d2f70556694de
comment:16 Changed 6 years ago by Dan Nixon
Merge branch '11447_workspaceindex_attribute_in_diffsphere' into 9198_add_diffsphere_support_to_convfit
Refs #11447
Full changeset: c63e541fb0b2f665c1c7a211a5ef0024b4d64c7a
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12286