Ticket #11495 (closed: fixed)
Add excluded detectors to ConvertCWPDMDToSpectra
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | VickieLynch |
Description (last modified by Wenduo Zhou) (diff)
And also enable ConvertSpiceDataToRealSpace to be corrected by detectors efficiency
Attachments
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
- Status changed from new to inprogress
Added new properties for new features. Refs #11495.
Changeset: fe8dc633b850918988694486768617eeec98e01c
comment:3 Changed 6 years ago by Wenduo Zhou
Refs #11495. Enabled to support detectors efficiency.
Of algorithm ConvertSpiceDataToReadSpace. And a unit test is added for the new feature.
On branch feature/11495_spice_pd_exlude_dets
Changes to be committed:
modified: ../Mantid/Framework/MDAlgorithms/inc/MantidMDAlgorithms/ConvertSpiceDataToRealSpace.h modified: ../Mantid/Framework/MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp modified: ../Mantid/Framework/MDAlgorithms/src/ConvertSpiceDataToRealSpace.cpp modified: ../Mantid/Framework/MDAlgorithms/test/ConvertSpiceDataToRealSpaceTest.h
Changeset: f0ff5df880c070b530f8f4824da5efbf7bb56128
comment:4 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #536.
comment:5 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to reopened
- Resolution fixed deleted
comment:6 Changed 6 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Tried to fix cppcheck error. Refs #11495.
Changeset: e144dcf7c7beae4832cfedf26e40b18ca40cc018
comment:7 Changed 6 years ago by Wenduo Zhou
Refs #11495. Checkpointing adding excluded detector IDs.
to ConvertCWPDMDToSpectra.
Changeset: d0681d6d7fa1a2a7a950c3e5901df2ebbf3d5328
comment:8 Changed 6 years ago by Wenduo Zhou
Refs #11495. Implemented exclusion of detectors.
In algorithm ConvertCWPDMDToSpectra and added unit test for this new feature.
Changeset: f6c70ef303263406b115eb385be34d076a0ae23e
comment:10 Changed 6 years ago by Wenduo Zhou
Jenkins, retest this please
comment:11 Changed 6 years ago by Wenduo Zhou
The issue is fixed. The broke build of Windows is caused by some irrelevant algorithm.
Test Result (1 failure / +1)
docs.algorithms/CutMD-v1.Example4D
There are two issues that are resolved in this ticket.
- A DetectorEfficiencyTableWorkspace is added to the properties of *ConvertSpiceDataToRealSpace*; It is not obvious to see its impact on the output MDEVentWorkspace, though. You can check the unit test for this feature and codes as well.
- *ConvertCWPDMDToSpectra* has a new input property *ExcludedDetectorIDs* for detectors to be excluded. You can refer to [trac](http://trac.mantidproject.org/mantid/ticket/11495) for the script and data file. As you exclude the detectors from ID 20 to 30, you can see part of the spectrum is set to zero.
comment:12 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 6 years ago by VickieLynch
- Status changed from verifying to closed
- Tester set to VickieLynch
Merge pull request #536 from mantidproject/feature/11495_spice_pd_exlude_dets
Enable ConvertCWPDMDToSpectra to exclude detectors
Full changeset: c1e41d35ea301ac9bd91b500f016b1a962792e6c
comment:15 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12333
