Ticket #11569 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Replace LastModifiedDate in IDF with a checksum

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.5
Component: Framework Keywords: MAINTENANCE
Cc: Alex.Buts@… Blocked By:
Blocking: #11565, #11818 Tester: Karl Palmen

Description

The lastmodified date in the IDF is a poor proxy for a checksum and in only used in mangling the instrument name in the IDS.

Now we have a ChecksumHelper we should use that, create a SHA1 or MD5 and use that instead in the IDS name.

  1. Change the name mangling to use the checksum instead (including for text in nexus files).
  2. Change the IDF files to remove the date
  3. Change the concepts docs that mention this
  4. Make sure the SNS IDF generator scripts no longer include this
  5. Change the xml schema to remove the need for this field.

Change History

comment:1 Changed 5 years ago by Nick Draper

  • Status changed from new to inprogress

re #11569 change date to checksum

Changeset: 969bca7c7e97acd0c125fb1363b7914e497f1e27

comment:2 Changed 5 years ago by Alex Buts

  • Cc Alex.Buts@… added

comment:3 Changed 5 years ago by Nick Draper

re #11569 missed an important line

Changeset: 5e75fae4c3e1ed4398c40cc6ace30ea98d1a6147

comment:4 Changed 5 years ago by Nick Draper

re #11569 file contents should be unix line endings and trimmed

Changeset: 524723cc29b8770202c43ff9006377caeb021d13

comment:5 Changed 5 years ago by Nick Draper

  • Blocking 11817 added

comment:5 Changed 5 years ago by Nick Draper

  • Blocking 11817 removed

Changes to IDF#s cannot happen until the code is in place as updates to the IDFs would go out immediately.

Follow on ticket for this. #11817

comment:6 Changed 5 years ago by Alex Buts

  • Blocking 11565 added

comment:8 Changed 5 years ago by Nick Draper

re #11569 update to comcepts doc

Changeset: 8615c30cc47e83475bfd267b65b38bfa35a26cd2

comment:9 Changed 5 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

testing as ​​https://github.com/mantidproject/mantid/pull/776

comment:10 Changed 5 years ago by Nick Draper

  • Blocking 11818 added

comment:11 Changed 5 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:12 Changed 5 years ago by Karl Palmen

Test failed on LET instrument. Instrument view is unchanged even if a door is removed.

The only difference I noticed was that if the instrument definition file is updated, it took just as long to load as it did first time, but if the file is not updated loading is quicker.

comment:13 Changed 5 years ago by Karl Palmen

Yes the file is used to test this does have an embedded xml definition.

comment:14 Changed 5 years ago by Karl Palmen

I've tested again with a Nexus file without embedded IDF and a raw file. I both cases, I saw part of the instrument move when loading after modifying the IDF file as described.

comment:15 Changed 5 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge pull request #776 from mantidproject/feature/11569_IDF_use_checksum_in_name_mangling

Change IDF name mangling to use SHA1 rather than last modified date

Full changeset: ​612f3b571ca2bb06d87b758e1b3451cf8ed6e383

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12407

Note: See TracTickets for help on using tickets.