Ticket #11585 (closed: fixed)
Reduce pylint warnings
Reported by: | Andrei Savici | Owned by: | Andrei Savici |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.4 |
Component: | Python | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Harry Jeffery |
Description
- disable warnings for files generated by pyuic4
- reduce other warnings
Change History
comment:2 Changed 5 years ago by Andrei Savici
more warnings. Refs #11585
Changeset: 747b47166d3836eac0a9fb4d8d3879bef77103ce
comment:3 Changed 5 years ago by Andrei Savici
pylint stuff. refs #11585
Changeset: abab67f9a542153011b4825d00d0d29941bac064
comment:4 Changed 5 years ago by Andrei Savici
Mostly UI. refs #11585
Changeset: 0b3693eb8624c9a84bf6a6c07838f8e5c145a1d9
comment:5 Changed 5 years ago by Andrei Savici
More UI. Refs #11585
Got tired of Pychop warnings. Skipped those files. It is going to be reimplemented anyway.
Changeset: 554a401e68a4cc01062aa34e7be67fe8caca99d0
comment:6 Changed 5 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #612.
comment:7 Changed 5 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:8 Changed 5 years ago by Harry Jeffery
Other than the comments I raised above (the indentation in string thing happens several more times) this looks good.
comment:9 Changed 5 years ago by Andrei Savici
The indentation has to match the outer parenthesis. So if I have abc(def(alpha,beta,gamma),doc='test'), I need to indent
abc(defg(alpha,
beta, gamma),
doc='test')
comment:10 Changed 5 years ago by Harry Jeffery
Ah, that makes sense. I hadn't noticed the parenthesise.
comment:11 Changed 5 years ago by Andrei Savici
Fix build errors. Refs #11585
Changeset: 0318ea656515b20a34a22431ec91e8e62c038d63
comment:12 Changed 5 years ago by Stuart Campbell
- Status changed from verifying to closed
Merge pull request #612 from mantidproject/11585_pylint
11585 pylint
Full changeset: 4b2121bbeb77c9a89e4c3a1caf50426ff850aac7
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12423
Pylint warnings. Refs #11585
Changeset: e1086dde1e205a32b59d84c4ce6e9bd137ad483e