Ticket #11667 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

ConvertToYSpace should optionally also output q-space

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The q-space values are calculated in the algorithm anyway so being able to output them would be simple.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Initial attempt to output Q values

Refs #11667

Changeset: 59797cb7fc43fb48922eab02943abf47b855a69f

comment:3 Changed 5 years ago by Dan Nixon

Set Q X axis unit Refs #11667

Changeset: e99ed571f169e4ad02501a57c2f46a952fdb2be9

comment:4 Changed 5 years ago by Dan Nixon

Update unit test to check q values

Refs #11667

Changeset: fdf5673f7e66683b413ed71c7b887ea751c1fb39

comment:5 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #734.

comment:6 Changed 5 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 5 years ago by Roman Tolchenov

I have this error:

` ConvertToYSpace: ComptonProfile - Unable to find component parameter "t0". Error in execution of algorithm ConvertToYSpace: ConvertToYSpace: error (see log) `

comment:8 Changed 5 years ago by Dan Nixon

My mistake, I left a step out of the testing instructions. Run this after loading the data: SetInstrumentParameter('ws_name', ParameterName='t0',ParameterType='Number',Value='0.5')

comment:9 Changed 5 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #734 from mantidproject/11667_add_q-space_output_to_COnvertToYSpace

Add optional q-Space output workspace to ConvertToYSpace

Full changeset: 9c50ef2dcfa5f32c86767da4b3c5f8a333de7093

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12505

Note: See TracTickets for help on using tickets.