Ticket #11668 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

ConvertToDistribution bug

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: minor Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

  • ConvertToDistribution takes any sort of MatrixWorkspace even event workspaces.
  • Create an MDEventWorkspace and try to do this 
    ConvertToDistribution(eventws)
  • When you try to run it with an event workspace it complains :

EventWorkspace: dataY cannot return a non-const array: you can’t modify the histogrammed data in an EventWorkspace

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

To reproduce: 

ws = CreateSampleWorkspace()
ws2 = ConvertToEventWorkspace(ws)
ws3 = ConvertToDistribution(ws2)

comment:2 Changed 5 years ago by Harry Jeffery

Refs #11668 Validate inputs to ConvertToDistribution

Changeset: d9ad234ea2e68fb59840e9455332906241c61c83

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11668 Internally check for event workspaces

Changeset: ea1299a40f7d1754effd4eca442f2f519ba9c5eb

comment:4 Changed 5 years ago by Harry Jeffery

Refs #11668 Document restricted input

Changeset: 496b6009030b0195ab9b6ac76c8ac0b41eb1908a

comment:5 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #692.

comment:6 Changed 5 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:7 Changed 5 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #692 from mantidproject/11668_converttodistribution

Validate ConvertToDistribution inputs

Full changeset: ​044847fd9ad3f9c1a6fb7c4f7fa081b9e18875d7

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12506

Note: See TracTickets for help on using tickets.