Ticket #11672 (closed: fixed)
Fix ties for FunctionParameterDecorator in CompositeFunction
| Reported by: | Michael Wedel | Owned by: | Michael Wedel |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Federico Montesino Pouzols |
Description
Currently, ties are not working when for functions that are wrapped by a FunctionParameterDecorator and part of a CompositeFunction. This is relevant for example in the case of PoldiFitPeaks2D.
After some debugging, it turned out that simply forwarding the tie-related methods is not enough in all cases. For the protected addTies method to work correctly, FunctionParameterDecorator needs to be a friend class of IFunction, just like CompositeFunction.
Change History
comment:2 Changed 5 years ago by Michael Wedel
Refs #11672. Added fix and another test
Changeset: c68375b479854444a867f05d0285ca91794ef5fa
comment:3 Changed 5 years ago by Michael Wedel
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #696.
comment:4 Changed 5 years ago by Michael Wedel
Refs #11672. Fixed outdated comment.
Changeset: 196a3e6ee6892b9332506256666feb568b7422cd
comment:5 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:6 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #696 from mantidproject/11672_fix_ties_for_function_parameter_decorator
Fix ties for FunctionParameterDecorator inside a CompositeFunction
Full changeset: b9bbd37fc7039fef0055866c471562629ed84a44
Refs #11672. Added failing unit test
Changeset: 114d749c04b93b6fa1205651d748098c92118726