Ticket #11691 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Make sure that sample Bilby script runs.

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: SANS Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Anders-Markvardsen

Description

Currently the sample script of Anders for the Bilby group does not load because the data sets do not contain monitors. It fails at 

        if isinstance(outWs, IEventWorkspace):
             LoadNexusMonitors(self._data_file, OutputWorkspace=monitor_ws_name)

        else:
            if monitor_ws_name in mtd:
                DeleteWorkspace(monitor_ws_name)

in isis_reduction_steps.py

We need to hedge for data which does not contain montiors, such as BILBY.

The current goal is to have the attached script pass.

Attachments

Bilby_through_reduction_framework.py​ (1.7 KB) - added by Anton Piccardo-Selg 5 years ago.
Bilby_through_reduction_framework_Anders.py​ (1.7 KB) - added by Anton Piccardo-Selg 5 years ago.
Bilby_through_reduction_framework_Anders.2.py​ (1.7 KB) - added by Anton Piccardo-Selg 5 years ago.

Change History

Changed 5 years ago by Anton Piccardo-Selg

comment:1 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from new to inprogress

Refs #11691 Hedge for event data without monitors

Changeset: 2064893bea3fd2ac0c885443db4030db1c6058e1

comment:2 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #714.

comment:3 Changed 5 years ago by Anton Piccardo-Selg

Refs #11691 Fix access to valueerror in reduction steps

Changeset: 217295887f59c653268fb3cf251a063cd727db2e

Changed 5 years ago by Anton Piccardo-Selg

Changed 5 years ago by Anton Piccardo-Selg

comment:4 Changed 5 years ago by Anders-Markvardsen

  • Status changed from verify to closed
  • Tester set to Anders-Markvardsen

Merge pull request #714 from mantidproject/feature/11691_allow_event_data_without_monitors

Hedge for event data without monitors

Full changeset: ​e0f235db4716825528209cd75dcb191709147832

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12529

Note: See TracTickets for help on using tickets.