Ticket #11869 (closed: fixed)
DetCal bug
| Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Federico Montesino Pouzols |
Description
TOPAZ user used old DetCal file with detector 58 on 2015 TOPAZ geometry without that bank. Detector 49 was moved to the position of detector 58.
Attachments
Change History
comment:2 Changed 5 years ago by anonymous
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #819.
comment:3 Changed 5 years ago by Federico Montesino Pouzols
Is this a fix for a 3.4.1 patch release, or for 3.5? In any case, beware that it seems that this has been branched from the v3.4.0 tag, so it contains the dangerous version number change in Code/Mantid/Build/CMake/VersionNumber.cmake. Please check this and rebase / revert the undesired commits if needed.
Oh no, the DownloadFileTest failure is back...
comment:4 Changed 5 years ago by Vickie Lynch
- Keywords Patch candidate removed
Rebased with master for 3.5 nightly build which will be available for users.
comment:5 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:6 Changed 5 years ago by Federico Montesino Pouzols
All looks fine, I'm ignoring an unrelated failure on win7 which had been built perfectly fine before with the same code changes.
comment:7 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #819 from mantidproject/11869_detcal_nonexisting_bank
LoadIsawDetCal bug fixed
Full changeset: a13ea1d816baf7627e181d5b23534ee95c54cb71
Refs #11869 do nothing if bank does not exist
Changeset: 2d137ea06d718051c1e24a94d565a8931aa40d67