Ticket #11870 (closed: fixed)
Rename ranges in elastic window algorithms
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.5 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #11885 | Tester: | Raquel Alvarez |
Description
Range1 and Range2 are not the best names, they should be integration and background.
Change History
comment:2 Changed 5 years ago by Dan Nixon
- Status changed from assigned to inprogress
Ranem ElasticWindow ranges Refs #11870
Changeset: 012a1aebd97c1212f1129e9698aff9cc96139e0f
comment:3 Changed 5 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #822.
comment:4 Changed 5 years ago by Raquel Alvarez
- Status changed from verify to verifying
- Tester set to Raquel Alvarez
comment:5 Changed 5 years ago by Raquel Alvarez
Also, a user example is missing. Not sure if this PR is the right place to add it or if a new ticket should be created.
comment:7 Changed 5 years ago by Dan Nixon
@raquelalvarezbanos Good point on the validation messages.
I think the reason ElasticWindowMultiple has no doctest is that it is very similar to ElasticWindow, although I think really there should be at least to show the expected output. I'll add a new ticket for this.
comment:9 Changed 5 years ago by Raquel Alvarez
Windows failed because of unrelated MDNormDirectSC-v1 doc test failure.
comment:10 Changed 5 years ago by Raquel Alvarez
- Status changed from verifying to closed
Merge pull request #822 from mantidproject/11870_rename_elasticwindow_ranges
Rename ElasticWindow(Multiple) ranges
Full changeset: c395773fed629d14c73d86ea66f76aac9d7cc374
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12708
