Ticket #11871 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Delete ConfigService hacks around removing properties

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.5
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

We now require Poco version >= 1.42, which contains the Poco::AbstractConfiguration::remove member. This member was missing on older versions so we had to implement a work around.

The work around should be removed to simplify the code.

Change History

comment:1 Changed 5 years ago by Martyn Gigg

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Martyn Gigg

Remove hacks in ConfigService for older Poco versions

Older versions of Poco didn't have an AbstractConfiguration::remove member so we had to fake it. This is no longer required as we need the newer versions due to other bug fixes. Refs #11871

Changeset: e1d866e9816ebab70fb636074a8988627575b190

comment:3 Changed 5 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #821.

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 5 years ago by Martyn Gigg

I don't know what is happening with the pylint build but it's certainly not related to these changes.

comment:6 Changed 5 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #821 from mantidproject/11871_rm_configservice_hacks

Remove hacks in ConfigService for older Poco versions

Full changeset: ​fe0e046e1d79786c95578f653587a2a16b38a140

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12709

Note: See TracTickets for help on using tickets.