Ticket #11886 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Replace reduction script if sample script is outdated

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Logical bug has been identified in operating isis configuration script.

If sample script have changed and previous configuration script existed, the reduction script remains untouched.

The sample reduction script should be replaced by new one if user have not touched it and sample reduction script have changed.

Change History

comment:1 Changed 5 years ago by Alex Buts

  • Status changed from new to inprogress

Re #11886 This should fix the issue.

Changeset: d70c2f52194964e7862378d01034d3c31f088ec1

comment:2 Changed 5 years ago by Alex Buts

Release Notice:

This is minor bugfix to autoconfiguration scrip which runs on ISIS analysis machines and creates user environment for new users.

Part of work for improving the logic of working with this script.

If newer version of the script appears in source repository, the previously untouched sample scripts will be replaced.

comment:3 Changed 5 years ago by Alex Buts

Re #11886 Do not replace old configs and Pylint warnings

Changeset: 55038a0444377f18ee5edd0637821229bfc56a64

comment:4 Changed 5 years ago by Alex Buts

Re #11886 Should fix unit test on Unix

and better logic behind replacing sample file.

Changeset: 7fb7b1d53ffccb710dd22a4bd2918dbde039ceec

comment:5 Changed 5 years ago by Alex Buts

Fixed as PR https://github.com/mantidproject/mantid/pull/842. See notes there on how to test.

comment:6 Changed 5 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:8 Changed 5 years ago by Federico Montesino Pouzols

The changes are tested and well documented, they look fine. Let's merge this fix in so users can check it.

The only issue that I could find is that there are some 15 pylint warnings in ISISDirecInelasticConfig.py (some of them are trivial to fix nitpicky thingies, like trailing spaces). But this has not been introduced in this branch, so let's merge the fix in.

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #842 from mantidproject/11886_ReplaceSampleReductionForUsers

Replace sample users script by its updated version if present

Full changeset: 65a45cd1b6e7ee6d63d027f6df4858d769c04f0f

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12724

Note: See TracTickets for help on using tickets.